Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add google_project_service_identity #2430

Merged
merged 16 commits into from
Aug 27, 2020
Merged

Add google_project_service_identity #2430

merged 16 commits into from
Aug 27, 2020

Conversation

umairidris
Copy link
Contributor

@umairidris umairidris commented Aug 26, 2020 •
edited by rileykarson
Loading

@ghost ghost added size/m labels Aug 26, 2020
@ghost ghost requested a review from rileykarson August 26, 2020 20:14
@umairidris umairidris mentioned this pull request Aug 26, 2020
Closed
@ghost ghost added size/l and removed size/m labels Aug 26, 2020
@ghost ghost added size/m and removed size/l labels Aug 26, 2020
@umairidris umairidris changed the title [WIP] Add google_project_service_identity Add google_project_service_identity Aug 26, 2020
rileykarson
rileykarson reviewed Aug 26, 2020
View reviewed changes
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a documentation page for the resource as well?

google-beta/resource_project_service_identity.go Show resolved Hide resolved
google-beta/resource_project_service_identity.go Outdated Show resolved Hide resolved
google-beta/resource_project_service_identity_test.go Outdated Show resolved Hide resolved
google-beta/resource_project_service_identity.go Show resolved Hide resolved
google-beta/resource_project_service_identity.go Outdated Show resolved Hide resolved
@ghost ghost added size/l and removed size/m labels Aug 26, 2020
rileykarson
rileykarson approved these changes Aug 27, 2020
View reviewed changes
Copy link
Collaborator

@rileykarson rileykarson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- I'll upstream this to Magic Modules and merge there at the same time as I merge this.

@rileykarson rileykarson mentioned this pull request Aug 27, 2020
Merged
5 tasks
@rileykarson rileykarson merged commit 5c732a7 into hashicorp:master Aug 27, 2020
This was referenced Aug 27, 2020
Merged
Merged
@umairidris umairidris deleted the service_identity branch September 10, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danawillow danawillow danawillow left review comments

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umairidris @danawillow @rileykarson