Skip to content

Resource Identity: Add more framework smoke tests #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 15, 2025
Merged

Resource Identity: Add more framework smoke tests #340

merged 16 commits into from
May 15, 2025

Conversation

@austinvalle
Copy link
Member

@austinvalle austinvalle commented May 2, 2025 •
edited
Loading

This PR does the following in both protocol v5 + v6 framework providers

  • Updates the existing framework identity resource + test to support identity and ID importing
  • Adds a test to ensure changing identities raise an error from the SDK
  • Updates the move resource to support moving identity + adds a test for moving identity

@austinvalle austinvalle requested a review from a team as a code owner May 2, 2025 21:44
@austinvalle austinvalle force-pushed the av/fw-identity-tests branch from 4b92bca to f1516b5 Compare May 8, 2025 20:54
austinvalle
austinvalle commented May 9, 2025
View reviewed changes
@austinvalle austinvalle mentioned this pull request May 9, 2025
Merged
@austinvalle austinvalle force-pushed the av/fw-identity-tests branch from 0d05cf2 to 55a97a5 Compare May 13, 2025 14:09
rainkwan
rainkwan previously approved these changes May 13, 2025
View reviewed changes
ansgarm
ansgarm approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@austinvalle austinvalle merged commit b741f11 into main May 15, 2025
100 checks passed
@austinvalle austinvalle deleted the av/fw-identity-tests branch May 15, 2025 18:35
brandonc pushed a commit to brandonc/terraform-provider-corner that referenced this pull request May 28, 2025
@austinvalle @brandonc
Resource Identity: Add more framework smoke tests (hashicorp#340)
e22e523 
* add import to existing test and negative change validation test

* add move rpc tests

* add import to existing test and negative change validation test

* add move rpc tests

* update tests with new framework validation

* update protov6 provider

* update to use latest commit in open PR

* add import to existing test and negative change validation test

* add move rpc tests

* update tests with new framework validation

* update protov6 provider

* update to use latest commit in open PR

* memes reign supreme
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ansgarm ansgarm ansgarm approved these changes

@rainkwan rainkwan rainkwan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@austinvalle @ansgarm @rainkwan