Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_media_transform #9663

Merged
merged 20 commits into from
Dec 10, 2020
Merged

New resource: azurerm_media_transform #9663

merged 20 commits into from
Dec 10, 2020

Conversation

jcanizalez
Copy link
Contributor

Including the support for new resource azurerm_media_transform. This PR resolves #9610

Checked:

  • Update Documentation
  • Add new Acceptance Test and verified that the tests pass successfully
  • Check linting

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez - I've given this review and left some comments inline. I the resource might be easier to use with a preset block per type? WDYT?

website/docs/r/media_transform.html.markdown Outdated Show resolved Hide resolved
website/docs/r/media_transform.html.markdown Outdated Show resolved Hide resolved
azurerm/internal/services/media/transform_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/media/transform_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/media/transform_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/media/transform_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/media/transform_resource.go Outdated Show resolved Hide resolved
@ghost ghost added size/XXL and removed size/XL labels Dec 8, 2020
@jcanizalez
Copy link
Contributor Author

jcanizalez commented Dec 8, 2020

Thanks @katbyte I applied your suggestion and I changed too presets to use one preset block for type. You can continue reviewing

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez - just one more set of comments about sets to resolve and this should be good to merge!

@jcanizalez
Copy link
Contributor Author

Thanks @katbyte I already applied your suggestions. So you can continue reviewing.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez! this LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests look good 👍

@tombuildsstuff tombuildsstuff merged commit 8a69ea4 into hashicorp:master Dec 10, 2020
tombuildsstuff added a commit that referenced this pull request Dec 10, 2020
@ghost
Copy link

ghost commented Dec 10, 2020

This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.40.0"
}
# ... other configuration ...

@jcanizalez jcanizalez deleted the azurerm_media_transform branch December 10, 2020 23:02
@ghost
Copy link

ghost commented Jan 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Transforms in Azure Media Services Account
3 participants