Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Resource Formatters now use a local Subscription ID #9423

Closed
wants to merge 30 commits into from

Conversation

tombuildsstuff
Copy link
Contributor

This PR moves away from using the global "subscriptionId" on the IDFormatter interface in favour of a local SubscriptionID parsed out on a per-ID basis. This is required for #9421 (and some other future work) - whilst this is incomplete I'll send a follow up in the morning

@tombuildsstuff tombuildsstuff added this to the v2.38.0 milestone Nov 23, 2020
@tombuildsstuff tombuildsstuff requested a review from a team November 23, 2020 18:25
@ghost ghost added the size/XXL label Nov 23, 2020
@WodansSon
Copy link
Collaborator

WodansSon commented Nov 24, 2020

@tombuildsstuff The iothub digital twins one has been renamed and moved into it's own digitaltwins service folder in PR #9430

@tombuildsstuff
Copy link
Contributor Author

Closing in favour of #9440

@tombuildsstuff tombuildsstuff deleted the r/id-formatter branch November 24, 2020 14:30
@ghost
Copy link

ghost commented Nov 27, 2020

This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.38.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants