New Resource: azurerm_service_fabric_mesh_local_network
#8838
Conversation
mbfrahry
commented
Oct 11, 2020
•
mbfrahry
commented
mbfrahry
changed the title
azurerm_service_fabric_mesh_networkazurerm_service_fabric_mesh_local_network
mbfrahry
added
service/service-fabric-mesh
There was a problem hiding this comment.
Thanks @mbfrahry - Couple of questions / suggestions below, but otherwise LGTM.
Side note - Is it worth updating for the new file naming convention we've started moving to while it's a new resource? (i.e. service_fabric_mesh_network_resource.go)
| return nil, fmt.Errorf("[ERROR] Unable to parse Service Fabric Mesh Network ID %q: %+v", input, err) | ||
| } | ||
|
|
||
| cluster := ServiceFabricMeshNetworkId{ |
There was a problem hiding this comment.
Copy-paste error?
| cluster := ServiceFabricMeshNetworkId{ | |
| network := ServiceFabricMeshNetworkId{ |
| return fmt.Errorf("retrieving Service Fabric Mesh Local Network %q (Resource Group %q): %+v", name, resourceGroup, err) | ||
| } | ||
|
|
||
| if resp.ID == nil { |
There was a problem hiding this comment.
Worth checking for empty string here too?
| name = "accTest-%d" | ||
| resource_group_name = azurerm_resource_group.test.name | ||
| location = azurerm_resource_group.test.location | ||
| network_address_prefix = "10.0.0.0/22" |
There was a problem hiding this comment.
Worth checking if this value updates successfully? I can see it being the contentious item if it doesn't work as expected, albeit used rarely.
|
This has been released in version 2.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.33.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
