Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read DNS names and Emails from certificate data if not found in SDK object #8631

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

sirlatrom
Copy link
Contributor

Fixes #8630.

@ghost ghost added the size/XS label Sep 25, 2020
@sirlatrom
Copy link
Contributor Author

@tombuildsstuff Does this fix need more work or can it be merged?

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - apologies for the delayed review here @sirlatrom 👍

@tombuildsstuff
Copy link
Contributor

Rebased this - tests pass:

Screenshot 2020-12-16 at 14 04 18

@tombuildsstuff tombuildsstuff merged commit d62a36c into hashicorp:master Dec 16, 2020
tombuildsstuff added a commit that referenced this pull request Dec 16, 2020
@sirlatrom sirlatrom deleted the fix-8630 branch December 16, 2020 13:48
@ghost
Copy link

ghost commented Dec 17, 2020

This has been released in version 2.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.41.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_key_vault_certificate: dns_names not read back from certificate issuer issued certificate
3 participants