-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_role_definition: don't add scope
to assignable_scopes
#8624
azurerm_role_definition: don't add scope
to assignable_scopes
#8624
Conversation
The two failures in the test result seems unrelated to my changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @magodo
Thanks for this PR, I've suggested a way to avoid a breaking change here that I believe should work correctly. It will require the tests to be updated also.
azurerm/internal/services/authorization/role_definition_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/authorization/role_definition_resource.go
Outdated
Show resolved
Hide resolved
@jackofallops Thank you for your comments, I have updated the code and added another test for the case that no assinable scopes is specified. Please take another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @magodo - this LGTM 👍
This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.45.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
fix #8577