Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_storage_account: adding support for account_kind being StorageV2 #851

Merged
merged 3 commits into from
Feb 19, 2018
Merged

azurerm_storage_account: adding support for account_kind being StorageV2 #851

merged 3 commits into from
Feb 19, 2018

Commits on Feb 16, 2018

  1. Upgrade storage API to 2017-10-01 

    - 2017-10-01 removed a lot of Context parameters from API calls, so
  sadly they had to be removed in order for this to compile.
- In addition, the storage account Create api uses a cancel-channel
  instead of a context, so this update passes in the ctx.Done() channel
  so that at least these operations can be cancelled.
- One good thing in this new version is that the Create API returns an
  account on a channel, so that the additional call to GetProperties is
  unnecessary to retrieve the account id
    @justenwalker
    justenwalker committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    9f68a06 View commit details
    Browse the repository at this point in the history

  2. Add support for StorageV2 account_kind 

    - Add StorageV2 to account_kind validation
- Allow access_tier to be set on StorageV2 kinds
    @justenwalker
    justenwalker committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    7201e61 View commit details
    Browse the repository at this point in the history

  3. Add StoargeV2 Test Cases

    @justenwalker
    justenwalker committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    fd75e8e View commit details
    Browse the repository at this point in the history