Add azuread auth to vnet gateway vpn client

[jon-walton]

This adds support for Azure Active Directory authentication to Virtual Network Gateway vpn clients.

fixes #6805
fixes #5079

[tombuildsstuff]

hey @jon-walton

Thanks for this PR :)

Taking a look through this is looking good - if we can fix up the comments then this otherwise LGTM 👍

Thanks!

[jon-walton]

Hi @tombuildsstuff . Thanks for taking a look so quickly. I've pushed the changes you've asked for

[tombuildsstuff]

hey @jon-walton

Thanks for pushing those changes - taking a look through here aside from one minor comment (which I hope you don't mind but I'm going to push a commit to fix) this otherwise LGTM 👍

Thanks!

[jon-walton]

Great, thank you!

[tombuildsstuff]

Tests seem fine (the only failing test 'TestAccAzureRMVirtualNetworkGatewayConnection_updatingSharedKey' is also failing in master, so is out-of-scope for this) 👍

[ghost]

This has been released in version 2.27.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.27.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!