Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontdoor: refactoring & ensuring ID's are consistent #8146

Merged
merged 41 commits into from
Aug 19, 2020
Merged

frontdoor: refactoring & ensuring ID's are consistent #8146

merged 41 commits into from
Aug 19, 2020

Commits on Aug 19, 2020

  1. internal/resourceid: adding an interface for Resource ID Rewriting

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    1e94b76 View commit details
    Browse the repository at this point in the history

  2. r/frontdoor: adding parsing functions

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    ed3992f View commit details
    Browse the repository at this point in the history

  3. r/frontdoor: switching the frontendEndpoints to use the custom parsers 

    Also fixing issues where fields aren't set into the state to ensure that
fields always have a value
    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    c1aa996 View commit details
    Browse the repository at this point in the history

  4. r/frontdoor: refactoring the backendpool flatten methods

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    536a5ed View commit details
    Browse the repository at this point in the history

  5. refactor: moving the frontdoor helpers into the frontdoor package

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    49ac731 View commit details
    Browse the repository at this point in the history

  6. r/frontdoor: refactoring the backend pool method

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    b560532 View commit details
    Browse the repository at this point in the history

  7. r/frontdoor: removing dead code

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    dcc75c3 View commit details
    Browse the repository at this point in the history

  8. refactor: ditching the frontdoor prefix

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    f47771d View commit details
    Browse the repository at this point in the history

  9. r/frontdoor: refactoring to use the ID parsers/formatters

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    4bbf894 View commit details
    Browse the repository at this point in the history

  10. r/frontdoor: switching to use the parser method for read/delete

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    9008060 View commit details
    Browse the repository at this point in the history

  11. r/frontdoor: fixing an issue where the checkdestroy function was chec… 

    …king the wrong resource name
    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    45fdddc View commit details
    Browse the repository at this point in the history

  12. r/frontdoor_firewall_policy: switching to use a consistent id formatter

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    d707f34 View commit details
    Browse the repository at this point in the history

  13. refactor: making the helper methods private now this is within the pa… 

    …ckage
    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    be9d0e2 View commit details
    Browse the repository at this point in the history

  14. firewall: placeholders to check the implementations are valid

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    365663c View commit details
    Browse the repository at this point in the history

  15. r/frontdoor_custom_https_configuration: fixing the id parsing

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    2e5a17d View commit details
    Browse the repository at this point in the history

  16. r/frontdoor*: adding import-time validators to check the ID is in the… 

    … correct format
    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    6b29cbf View commit details
    Browse the repository at this point in the history

  17. r/frontdoor_firewall_policy: refactoring

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    6320275 View commit details
    Browse the repository at this point in the history

  18. r/frontdoor_custom_https_configuration: ensuring CU calls Read and de… 

    …precating `resource_group_name`
    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    0b8a1aa View commit details
    Browse the repository at this point in the history

  19. r/frontdoor_custom_https_configuration: fixing the docs

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    56162c3 View commit details
    Browse the repository at this point in the history

  20. r/frontdoor_custom_https_configuration: adding a state migration to p… 

    …atch the ID
    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    345952a View commit details
    Browse the repository at this point in the history

  21. r/frontdoor: fixing a bug in the id formatters

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    8d23d6f View commit details
    Browse the repository at this point in the history

  22. r/frontdoor: exposing the correct resource id during a requires impor… 

    …t error
    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    62262eb View commit details
    Browse the repository at this point in the history

  23. resource-group: deprecated shouldn't be forcenew

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    d2d0026 View commit details
    Browse the repository at this point in the history

  24. r/frontdoor_firewall_policy: adding a state migration for the ID

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    6bc28d3 View commit details
    Browse the repository at this point in the history

  25. r/frontdoor: adding a state migration to fix the I

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a14dfff View commit details
    Browse the repository at this point in the history

  26. WIP

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    0176557 View commit details
    Browse the repository at this point in the history

  27. r/frontdoor: helps if you set the field

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    19544cc View commit details
    Browse the repository at this point in the history

  28. r/frontdoor: renaming the test files to match the resources

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    3462bf5 View commit details
    Browse the repository at this point in the history

  29. r/frontdoor_firewall_policy: location is computed

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    59ce804 View commit details
    Browse the repository at this point in the history

  30. docs: removing conflicting terms

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    3a7a074 View commit details
    Browse the repository at this point in the history

  31. r/frontdoor_firewall_policy: moving the validation tests over

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a5c8b47 View commit details
    Browse the repository at this point in the history

  32. r/frontdoor: rewriting the ID's to ensure they're consistent

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    1c38f16 View commit details
    Browse the repository at this point in the history

  33. frontdoor: tests for the ID Parsers

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    ef7e5ba View commit details
    Browse the repository at this point in the history

  34. r/frontdoor_custom_https_configuration: validating the ID is the corr… 

    …ect case at import time
    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    771075e View commit details
    Browse the repository at this point in the history

  35. r/frontdoor: ensuring the ID is consistent at import time

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    17b4258 View commit details
    Browse the repository at this point in the history

  36. typo

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    308f184 View commit details
    Browse the repository at this point in the history

  37. r/frontdoor_https_configuration: ensuring the Frontend Endpoint ID is… 

    … consistent
    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    33e3b80 View commit details
    Browse the repository at this point in the history

  38. frontdoor: moving the customizeDiff out

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    8762d5f View commit details
    Browse the repository at this point in the history

  39. fixing the assertion

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    36c7238 View commit details
    Browse the repository at this point in the history

  40. pr comments

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    2177727 View commit details
    Browse the repository at this point in the history

  41. linting

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    75223f4 View commit details
    Browse the repository at this point in the history