Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account - filter allow_blob_public_access and min_tls_version from Azure US Government #8092

Merged
merged 7 commits into from
Aug 13, 2020

Conversation

neil-yechenwei
Copy link
Contributor

fixes #7812
fixes #8083

@WodansSon WodansSon added azure/china azure/government upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR service/storage bug labels Aug 12, 2020
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neil-yechenwei, this mostly looks good to me but I think we need to tweak the logic a bit.

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neil-yechenwei, thanks for letting me work on this with you neil... the manual tests are now passing so I think this is good to go! 🚀

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@WodansSon WodansSon merged commit 6203446 into hashicorp:master Aug 13, 2020
WodansSon added a commit that referenced this pull request Aug 13, 2020
@WodansSon WodansSon added this to the v2.23.0 milestone Aug 13, 2020
@ghost
Copy link

ghost commented Aug 13, 2020

This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure/government bug documentation service/storage size/M upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
4 participants