Allow updating additional_capabilities

[NilsBusche]

Add update for additional_capabilities.

Allow updating ultra_ssd_enabled without recreation as mentioned in #7556

Fixes #7556

[tombuildsstuff]

aside from a couple of minor test bugs this LGTM - thanks for this @NilsBusche

[tombuildsstuff]

called out all of the references to be explicit - but if we can fix these test bugs up then this otherwise LGTM 👍

[NilsBusche]

called out all of the references to be explicit - but if we can fix these test bugs up then this otherwise LGTM 👍

Thanks for this advice. All occurrences should be fixed now.

[tombuildsstuff]

LGTM - thanks for pushing those changes @NilsBusche

[tombuildsstuff]

hey @NilsBusche

Apologies for the delayed re-review here!

I've run the tests for this but it appears the test configurations need to be updated to be deployed into a Zone so that UltraSSD can be used?

Error: Error creating Linux Virtual Machine "acctestVM-200824104601074216" (Resource Group "acctestRG-200824104601074216"): compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="UltraSSD can be used only with Virtual Machine in an Availability Zone." Target="additionalCapabilities.ultraSSDEnabled"

Thanks!

[NilsBusche]

hey @NilsBusche

Apologies for the delayed re-review here!

I've run the tests for this but it appears the test configurations need to be updated to be deployed into a Zone so that UltraSSD can be used?

Error: Error creating Linux Virtual Machine "acctestVM-200824104601074216" (Resource Group "acctestRG-200824104601074216"): compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="UltraSSD can be used only with Virtual Machine in an Availability Zone." Target="additionalCapabilities.ultraSSDEnabled"

Thanks!

Hi @tombuildsstuff, yes, this is correct. I will add this later.

But why has the automatic Travis CI been run successfully?

[tombuildsstuff]

@NilsBusche Travis only runs the Unit Tests (since these are quick) the Acceptance Tests on the other hand are only run in a separate CI system which since they take longer (and cost money, so we trigger these manually)

[NilsBusche]

@NilsBusche Travis only runs the Unit Tests (since these are quick) the Acceptance Tests on the other hand are only run in a separate CI system which since they take longer (and cost money, so we trigger these manually)

Hi @tombuildsstuff, thanks for this information. I added the zone attribute. Hopefully now everything is fine.

[tombuildsstuff]

Tests look good - thanks for pushing those changes @NilsBusche

[ghost]

This has been released in version 2.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.25.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!