New resource: azurerm_dedicated_hardware_security_module #7727
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -31,6 +31,7 @@ import ( | |||||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid" | ||||||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventhub" | ||||||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/frontdoor" | ||||||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/hardwaresecuritymodule" | ||||||
|
There was a problem hiding this comment.
Suggested change
and so on |
||||||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/hdinsight" | ||||||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/healthcare" | ||||||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/iotcentral" | ||||||
|
|
@@ -111,6 +112,7 @@ func SupportedServices() []common.ServiceRegistration { | |||||
| eventgrid.Registration{}, | ||||||
| eventhub.Registration{}, | ||||||
| frontdoor.Registration{}, | ||||||
| hardwaresecuritymodule.Registration{}, | ||||||
| hdinsight.Registration{}, | ||||||
| healthcare.Registration{}, | ||||||
| iothub.Registration{}, | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package client | ||
|
|
||
| import ( | ||
| "github.com/Azure/azure-sdk-for-go/services/preview/hardwaresecuritymodules/mgmt/2018-10-31-preview/hardwaresecuritymodules" | ||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/common" | ||
| ) | ||
|
|
||
| type Client struct { | ||
| DedicatedHsmClient *hardwaresecuritymodules.DedicatedHsmClient | ||
| } | ||
|
|
||
| func NewClient(o *common.ClientOptions) *Client { | ||
| dedicatedHsmClient := hardwaresecuritymodules.NewDedicatedHsmClientWithBaseURI(o.ResourceManagerEndpoint, o.SubscriptionId) | ||
| o.ConfigureClient(&dedicatedHsmClient.Client, o.ResourceManagerAuthorizer) | ||
|
|
||
| return &Client{ | ||
| DedicatedHsmClient: &dedicatedHsmClient, | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package parse | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure" | ||
| ) | ||
|
|
||
| type DedicatedHardwareSecurityModuleId struct { | ||
| ResourceGroup string | ||
| Name string | ||
| } | ||
|
|
||
| func DedicatedHardwareSecurityModuleID(input string) (*DedicatedHardwareSecurityModuleId, error) { | ||
| id, err := azure.ParseAzureResourceID(input) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("parsing DedicatedHardwareSecurityModule ID %q: %+v", input, err) | ||
| } | ||
|
|
||
| dedicatedHardwareSecurityModule := DedicatedHardwareSecurityModuleId{ | ||
| ResourceGroup: id.ResourceGroup, | ||
| } | ||
|
|
||
| if dedicatedHardwareSecurityModule.Name, err = id.PopSegment("dedicatedHSMs"); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err := id.ValidateNoEmptySegments(input); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return &dedicatedHardwareSecurityModule, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| package parse | ||
|
|
||
| import ( | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestDedicatedHardwareSecurityModuleID(t *testing.T) { | ||
| testData := []struct { | ||
| Name string | ||
| Input string | ||
| Expected *DedicatedHardwareSecurityModuleId | ||
| }{ | ||
| { | ||
| Name: "Empty", | ||
| Input: "", | ||
| Expected: nil, | ||
| }, | ||
| { | ||
| Name: "No Resource Groups Segment", | ||
| Input: "/subscriptions/00000000-0000-0000-0000-000000000000", | ||
| Expected: nil, | ||
| }, | ||
| { | ||
| Name: "No Resource Groups Value", | ||
| Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/", | ||
| Expected: nil, | ||
| }, | ||
| { | ||
| Name: "Resource Group ID", | ||
| Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/foo/", | ||
| Expected: nil, | ||
| }, | ||
| { | ||
| Name: "Missing DedicatedHardwareSecurityModule Value", | ||
| Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/group1/providers/Microsoft.HardwareSecurityModules/dedicatedHSMs", | ||
| Expected: nil, | ||
| }, | ||
| { | ||
| Name: "DedicatedHardwareSecurityModule ID", | ||
| Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/group1/providers/Microsoft.HardwareSecurityModules/dedicatedHSMs/hsm1", | ||
| Expected: &DedicatedHardwareSecurityModuleId{ | ||
| ResourceGroup: "group1", | ||
| Name: "hsm1", | ||
| }, | ||
| }, | ||
| { | ||
| Name: "Wrong Casing", | ||
| Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/group1/providers/Microsoft.HardwareSecurityModules/DedicatedHSMs/hsm1", | ||
| Expected: nil, | ||
| }, | ||
| } | ||
|
|
||
| for _, v := range testData { | ||
| t.Logf("[DEBUG] Testing %q..", v.Name) | ||
|
|
||
| actual, err := DedicatedHardwareSecurityModuleID(v.Input) | ||
| if err != nil { | ||
| if v.Expected == nil { | ||
| continue | ||
| } | ||
| t.Fatalf("Expected a value but got an error: %s", err) | ||
| } | ||
|
|
||
| if actual.ResourceGroup != v.Expected.ResourceGroup { | ||
| t.Fatalf("Expected %q but got %q for ResourceGroup", v.Expected.ResourceGroup, actual.ResourceGroup) | ||
| } | ||
|
|
||
| if actual.Name != v.Expected.Name { | ||
| t.Fatalf("Expected %q but got %q for Name", v.Expected.Name, actual.Name) | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package hardwaresecuritymodule | ||
|
|
||
| import "github.com/hashicorp/terraform-plugin-sdk/helper/schema" | ||
|
|
||
| type Registration struct{} | ||
|
|
||
| // Name is the name of this Service | ||
| func (r Registration) Name() string { | ||
| return "Hardware Security Module" | ||
| } | ||
|
|
||
| // WebsiteCategories returns a list of categories which can be used for the sidebar | ||
| func (r Registration) WebsiteCategories() []string { | ||
| return []string{ | ||
| "Hardware Security Module", | ||
| } | ||
| } | ||
|
|
||
| // SupportedDataSources returns the supported Data Sources supported by this Service | ||
| func (r Registration) SupportedDataSources() map[string]*schema.Resource { | ||
| return map[string]*schema.Resource{} | ||
| } | ||
|
|
||
| // SupportedResources returns the supported Resources supported by this Service | ||
| func (r Registration) SupportedResources() map[string]*schema.Resource { | ||
| return map[string]*schema.Resource{ | ||
| "azurerm_dedicated_hardware_security_module": resourceArmDedicatedHardwareSecurityModule(), | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bit long, could we maybe abbreviate it to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated