Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_frontdoor - Fix timeout for read operation to match documentation #7408

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

WodansSon
Copy link
Collaborator

@WodansSon WodansSon commented Jun 19, 2020

I have increased the timeout in the resource code from 5 minutes to 6 hours per the documentation. While this may seem excessive for a read, the time may be necessary for the frontdoor resource to complete successfully especially when custom domain SSL certs have been defined.

(fixes #7405)

@WodansSon WodansSon added this to the v2.16.0 milestone Jun 19, 2020
@ghost ghost added the size/XS label Jun 19, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit 39a96cd into master Jun 23, 2020
@katbyte katbyte deleted the b-frontdoor-timeout branch June 23, 2020 20:55
katbyte added a commit that referenced this pull request Jun 23, 2020
tombuildsstuff added a commit that referenced this pull request Jun 25, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
…tation (hashicorp#7408)

I have increased the timeout in the resource code from 5 minutes to 6 hours per the documentation. While this may seem excessive for a read, the time may be necessary for the frontdoor resource to complete successfully especially when custom domain SSL certs have been defined.

(fixes hashicorp#7405)
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
…tation (hashicorp#7408)

I have increased the timeout in the resource code from 5 minutes to 6 hours per the documentation. While this may seem excessive for a read, the time may be necessary for the frontdoor resource to complete successfully especially when custom domain SSL certs have been defined.

(fixes hashicorp#7405)
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
@ghost
Copy link

ghost commented Jul 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for Front Door resource has wrong read timeout value
2 participants