Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: updating github.com/hashicorp/terraform-plugin-sdk to v1.13.0 #6809

Merged
merged 37 commits into from
Jul 6, 2020

Conversation

tombuildsstuff
Copy link
Contributor

Since v1.12.0 of the Plugin SDK defaults to enabling Binary Testing - this PR disables this for the moment.

This also removes some invalid ConflictsWith fields caught by the Plugin SDK:

Internal validation of the provider failed! This is always a bug
        with the provider itself, and not a user issue. Please report
        this bug:

        3 errors occurred:
        	* resource azurerm_key_vault_certificate: ConflictsWith: days_before_expiry configuration block reference (certificate_policy.0.lifetime_action.0.trigger.0.lifetime_percentage) can only be used with TypeList and MaxItems: 1 configuration blocks
        	* resource azurerm_virtual_machine_scale_set: ConflictsWith: managed_disk_type configuration block reference (storage_profile_os_disk.vhd_containers) can only be used with TypeList and MaxItems: 1 configuration blocks
        	* resource azurerm_api_management: ConflictsWith: key_vault_id configuration block reference (hostname_configuration.0.portal.0.certificate) can only be used with TypeList and MaxItems: 1 configuration blocks

@tombuildsstuff tombuildsstuff added this to the v2.10.0 milestone May 7, 2020
@tombuildsstuff tombuildsstuff requested a review from a team May 7, 2020 08:58
@ghost ghost added the size/XXL label May 7, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte modified the milestones: v2.10.0, v2.11.0 May 14, 2020
@jackofallops jackofallops modified the milestones: v2.11.0, v2.12.0 May 21, 2020
@tombuildsstuff tombuildsstuff changed the title dependencies: updating github.com/hashicorp/terraform-plugin-sdk to v1.12.0 dependencies: updating github.com/hashicorp/terraform-plugin-sdk to v1.13.0 May 26, 2020
@katbyte katbyte modified the milestones: v2.12.0, v2.13.0 May 28, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.13.0, v2.14.0, v2.15.0 Jun 4, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - a couple of questions below, but otherwise LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 4c28cc0 into master Jul 6, 2020
@tombuildsstuff tombuildsstuff deleted the deps/plugin-sdk branch July 6, 2020 10:57
tombuildsstuff added a commit that referenced this pull request Jul 6, 2020
@bandesz
Copy link

bandesz commented Jul 6, 2020

Hey, did you accidentally commit tf.zip in? I don't have the context here, just wanted to double-check - as the file is in .gitignore.

@tombuildsstuff
Copy link
Contributor Author

@bandesz we did, apologies - I've removed this and force-pushed to master to remove it, so it should be gone now 👍

@ghost
Copy link

ghost commented Jul 10, 2020

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants