Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_frontdoor - Add support for backend_pools_send_receive_timeout_seconds #6604

Merged
merged 3 commits into from
Apr 29, 2020

Conversation

WodansSon
Copy link
Collaborator

(fixes #4558)

@ghost ghost added the documentation label Apr 25, 2020
@WodansSon WodansSon added this to the v2.8.0 milestone Apr 25, 2020
@WodansSon WodansSon requested a review from katbyte April 25, 2020 04:33
@WodansSon WodansSon changed the title [WIP]azurerm_frontdoor - Add support custom timeout for backend pool azurerm_frontdoor - Add support custom timeout for backend pool Apr 25, 2020
@WodansSon WodansSon changed the title azurerm_frontdoor - Add support custom timeout for backend pool azurerm_frontdoor - Add support for backend_pools_send_receive_timeout_seconds Apr 25, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @WodansSon - aside from 2 comments about naming this LGTM 👍

@@ -67,6 +67,13 @@ func resourceArmFrontDoor() *schema.Resource {
Required: true,
},

"backend_pools_send_receive_timeout_seconds": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be backend_pool_send_receive_timeout_in_seconds?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was originally going to call it that too, but after researching it, it's a global setting for all backend pools thus the plural. 🙂

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh see i would have assumed it was applying to all of them without the s, but there is another property backend_pool? which is different the the other back end pools i can see why heh

Comment on lines 856 to 859
result := frontdoor.BackendPoolsSettings{
EnforceCertificateNameCheck: enforceCheck,
SendRecvTimeoutSeconds: utils.Int32(backendPoolsSendReceiveTimeoutSeconds),
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there more settings here? would it make sense to move this into a backend_pool_configuration block?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I was thinking the same thing... but I wanted to avoid a breaking change so I just put it at the top level with the other backend pools settings. Not sure if we should pull it into a block yet, if another setting is exposed in a future API I think it would be appropriate to make the change at that time... Maybe open a 3.0 breaking change issue for this to fix in the future?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well we now have 2 so it makes sense to move into a block (especially when we have such long names) if we did it in 3.0 we would still ideally want to depreacate the old properties & support both so people have a migration path.

@WodansSon
Copy link
Collaborator Author

image

@WodansSon WodansSon merged commit fa644aa into master Apr 29, 2020
@WodansSon WodansSon deleted the fr_frontdoor_custom_timeout branch April 29, 2020 04:09
WodansSon added a commit that referenced this pull request Apr 29, 2020
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.8.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Frontdoor: support custom timeout for backend pool
2 participants