Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_monitor_diagnostic_setting - mark retention_policy & retention_policy as optional #6603

Merged
merged 3 commits into from
Apr 26, 2020

Conversation

nyuen
Copy link
Contributor

@nyuen nyuen commented Apr 24, 2020

modifying the Diagnostic settings schema to set the retention policy to Optional #5673

Some resources such as ActivityLogs do not support Retention Policy causing a change on subsequent Terraform apply even if the diagnostic setting. This is caused by a mismatch between the TFState and the object returned by the REST API

@ghost ghost added the size/M label Apr 24, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nyuen, thanks for this PR!

overall looks good but could we update the website? thanks!

@katbyte katbyte added this to the v2.8.0 milestone Apr 26, 2020
@katbyte katbyte changed the title monitor diagnostic settings to Optional azurerm_monitor_diagnostic_setting - mark retention_policy & retention_policy as optional Apr 26, 2020
@ghost ghost added the documentation label Apr 26, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nyuen, i hope you don't mind by i've pushed the required changes 🙂 LGTM 👍

@nyuen
Copy link
Contributor Author

nyuen commented Apr 26, 2020

thanks @katbyte, looks like the linter failed, I guess len(policiesRaw) != 0 should be sufficient.
One a side note do you have more inputs one how the tests are run? I've tried to added a failing this and go test monitor resource_arm_monitor_diagnostic_setting_test.go still passed somehow.

@ghost ghost removed the waiting-response label Apr 26, 2020
@katbyte
Copy link
Collaborator

katbyte commented Apr 26, 2020

heh thats why we have linters 🙂 - and sadly the api can returninconsistentt results depending on many things including region and timing. pushed a commit which should fix that up

@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.8.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants