Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_hdinsight_* - support for tls_min_version #6440

Merged
merged 3 commits into from
Apr 13, 2020

Conversation

kosinsky
Copy link
Contributor

Added support for min tls version for azurerm_hdinsight_*_cluster resources.

Sample configuration:

resource "azurerm_hdinsight_hadoop_cluster" "example" {
  name                = "example-hdicluster"
  resource_group_name = "${azurerm_resource_group.example.name}"
  location            = "${azurerm_resource_group.example.location}"
  cluster_version     = "3.6"
  tier                = "Standard"
  min_tls_version = "1.2" # possible values 1.0, 1.1, 1.2
.....
}

Tests:

make testacc TEST='./azurerm/internal/services/hdinsight/tests/' TESTARGS='-run=_tls  -parallel=1' TESTTIMEOUT='300m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
TF_ACC=1 go test ./azurerm/internal/services/hdinsight/tests/ -v -run=_tls  -parallel=1 -timeout 300m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMHDInsightHadoopCluster_tls
=== PAUSE TestAccAzureRMHDInsightHadoopCluster_tls
=== RUN   TestAccAzureRMHDInsightHBaseCluster_tls
=== PAUSE TestAccAzureRMHDInsightHBaseCluster_tls
=== RUN   TestAccAzureRMHDInsightInteractiveQueryCluster_tls
=== PAUSE TestAccAzureRMHDInsightInteractiveQueryCluster_tls
=== RUN   TestAccAzureRMHDInsightKafkaCluster_tls
=== PAUSE TestAccAzureRMHDInsightKafkaCluster_tls
=== RUN   TestAccAzureRMHDInsightMLServicesCluster_tls
=== PAUSE TestAccAzureRMHDInsightMLServicesCluster_tls
=== RUN   TestAccAzureRMHDInsightRServerCluster_tls
=== PAUSE TestAccAzureRMHDInsightRServerCluster_tls
=== RUN   TestAccAzureRMHDInsightSparkCluster_tls
=== PAUSE TestAccAzureRMHDInsightSparkCluster_tls
=== RUN   TestAccAzureRMHDInsightStormCluster_tls
=== PAUSE TestAccAzureRMHDInsightStormCluster_tls
=== CONT  TestAccAzureRMHDInsightHadoopCluster_tls
--- PASS: TestAccAzureRMHDInsightHadoopCluster_tls (953.94s)
=== CONT  TestAccAzureRMHDInsightMLServicesCluster_tls
--- PASS: TestAccAzureRMHDInsightMLServicesCluster_tls (1269.72s)
=== CONT  TestAccAzureRMHDInsightStormCluster_tls
--- PASS: TestAccAzureRMHDInsightStormCluster_tls (1024.41s)
=== CONT  TestAccAzureRMHDInsightSparkCluster_tls
--- PASS: TestAccAzureRMHDInsightSparkCluster_tls (1082.57s)
=== CONT  TestAccAzureRMHDInsightRServerCluster_tls
--- PASS: TestAccAzureRMHDInsightRServerCluster_tls (729.02s)
=== CONT  TestAccAzureRMHDInsightInteractiveQueryCluster_tls
--- PASS: TestAccAzureRMHDInsightInteractiveQueryCluster_tls (1146.04s)
=== CONT  TestAccAzureRMHDInsightKafkaCluster_tls
--- PASS: TestAccAzureRMHDInsightKafkaCluster_tls (815.68s)
=== CONT  TestAccAzureRMHDInsightHBaseCluster_tls
--- PASS: TestAccAzureRMHDInsightHBaseCluster_tls (1097.50s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/hdinsight/tests     8119.836s

Fixes: #6372

@ghost ghost added the size/XL label Apr 10, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @kosinsky! LGTM 👍

@katbyte katbyte added this to the v2.6.0 milestone Apr 12, 2020
@katbyte katbyte changed the title Support for minimum TLS version for HDInisght clusters azurerm_hdinsight_* - support for tls_min_version Apr 13, 2020
@katbyte katbyte merged commit cb8fa93 into hashicorp:master Apr 13, 2020
@ghost
Copy link

ghost commented Apr 16, 2020

This has been released in version 2.6.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.6.0"
}
# ... other configuration ...

@kosinsky kosinsky deleted the hdi-tls-version branch April 16, 2020 16:48
@ghost
Copy link

ghost commented May 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for minimum TLS version for HDInisght clusters
2 participants