Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource azurerm_spring_cloud_app #6384

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Apr 7, 2020

the second and last PR of #4891

a single app without deployments.

image

@njuCZ njuCZ changed the title new resource azurerm_spring_cloud_app, azurerm_spring_cloud_deployment and azurerm_spring_cloud_active_deployment new resource azurerm_spring_cloud_app Apr 23, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @njuCZ
Thanks for the updates to this PR, looking really good. I've run the tests on our CI, and they pass. Just 2 minor changes noted below and I think we'll be good to merge.

Ste

@jackofallops
Copy link
Member

Tests pass:
image

@jackofallops jackofallops added this to the v2.7.0 milestone Apr 23, 2020
@jackofallops jackofallops merged commit 235d89e into hashicorp:master Apr 23, 2020
jackofallops added a commit that referenced this pull request Apr 23, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@njuCZ njuCZ deleted the springcloudappdeployment branch April 24, 2020 02:13
@ghost
Copy link

ghost commented May 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants