Replaced 'count' to 'node_count' in kubernetes datasource

[jnehlt]

No description provided.

[jnehlt]

ISSUE URL

[jnehlt]

Fixes: #6094

[tombuildsstuff]

hi @jnehlt

Thanks for this PR :)

Taking a look through here unfortunately renaming the field being returned from the data source won't fix this, as the underlying count error being tracked in #6094 is due to a change in the behaviour of the SDK in the 2019-11-01 version of the AKS API.

We've been trying to consolidate this behaviour for the last couple of weeks - however unfortunately there's been several breaking changes to the AKS API during this time. As such we've been trying to consolidate the breaking changes to the API and the necessary changes needed to fix this (and several other) open AKS bugs and PR's.

After syncing up with the AKS Team earlier in the week, I've got a branch locally which fixes #6094 and some of the other issues/consolidates some of the other PR's, since unfortunately this requires a rather significant refactor).

Since this branch is nearly feature complete - our intention is to merge and ship this for the v2.5 release of the Azure Provider. As such, whilst I'd like to thank you for this contribution I'm going to close this PR for the moment.

Thanks!

[jnehlt]

Ok thanks @tombuildsstuff.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!