Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider misc cleanup - rg names & normalize location #6240

Closed
wants to merge 2 commits into from

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Mar 25, 2020

No description provided.

@katbyte katbyte added this to the v2.3.0 milestone Mar 25, 2020
@katbyte katbyte requested a review from a team March 25, 2020 01:17
@ghost ghost added the size/XL label Mar 25, 2020
@tombuildsstuff
Copy link
Contributor

Rather than making this generic method less strictly typed - I've opened #6242 which supersedes this by splitting the NormalizeLocation into 3 to give us more granular methods which can be more strongly typed, allowing us to lean on the Go compiler here:

  1. Normalize - taking a string returning a normalized string
  2. NormalizeNilable - for flattening nilable location fields to ensure there's always a value
  3. StateFunc - for flattening this into the state

@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@tombuildsstuff tombuildsstuff deleted the kt/misc-cleanup-rgname-normalizelocation branch April 17, 2020 07:27
@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants