Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_route - add validation to routing table name and route name (#6053) #6055

Merged
merged 6 commits into from
Apr 23, 2020

Conversation

yves-vogl
Copy link
Contributor

@yves-vogl yves-vogl commented Mar 10, 2020

Hi,

I'm trying to fix the issue I stumbled upon (#6053). Hope that helps.

Yves

Edit: Fixes #6053

@ghost ghost added the size/M label Mar 10, 2020
@yves-vogl
Copy link
Contributor Author

yves-vogl commented Mar 16, 2020

I've pulled in the latest master changes which fix the linting issues

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yves-vogl
Many thanks for the PR, good spot on the source of the issue!

I've made a couple of suggestions for an alternative implementation for the validation, could you check they meet your understanding of the naming limitations/requirements and commit if you're happy?

Thanks

azurerm/internal/services/network/validate.go Outdated Show resolved Hide resolved
azurerm/internal/services/network/validate.go Outdated Show resolved Hide resolved
@katbyte katbyte changed the title Adding validation function routing table name and route name (see #6053) azurerm_route - add validation to routing table name and route name (#6053) Mar 25, 2020
@ghost ghost added size/S and removed size/M labels Apr 16, 2020
@ghost ghost added size/XS and removed size/S labels Apr 16, 2020
@yves-vogl
Copy link
Contributor Author

Thanks for the suggestions! I really appreciate them. I accepted the suggestions and now are waiting for tests to complete.

@ghost ghost removed the waiting-response label Apr 16, 2020
@yves-vogl
Copy link
Contributor Author

Please do not close the PR - I encountered the same issue for SecurityGroupRules and we'd like to fix it, too.

Error: Error Creating/Updating Network Security Rule "80/TCP" (NSG "proxy" / Resource Group "****-infrastructure"): network.SecurityRulesClient#CreateOrUpdate: Failure sending request: StatusCode=404 -- Original Error: Code="Failed" Message="The async operation failed." AdditionalInfo=[{"Message":"No HTTP resource was found that matches the request URI 'https://westeurope.network.azure.com:30056/<guid>subscriptions/<guid>/resourceGroups/<resourcegroup>/providers/Microsoft.Network/networkSecurityGroups/proxy/securityRules/80/TCP?api-version=2019-09-01'."}]

@jackofallops
Copy link
Member

Please do not close the PR - I encountered the same issue for SecurityGroupRules and we'd like to fix it, too.

Hi @yves-vogl - Probably best to PR that change separately. I'll check this over and try to get it merged for the the 2.7 release later today.

@jackofallops jackofallops added this to the v2.7.0 milestone Apr 23, 2020
@jackofallops
Copy link
Member

Associated resource tests pass:
image

@jackofallops jackofallops merged commit e85d13e into hashicorp:master Apr 23, 2020
jackofallops added a commit that referenced this pull request Apr 23, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@kishori0306
Copy link

I encountered the same issue for Subnet.

Error: Error Creating/Updating Subnet "1.0.1.0/24-subnet" (Virtual Network "web-server-vnet" / Resource Group "web-rg"): network.SubnetsClient#CreateOrUpdate: Failure sending request: StatusCode=404 -- Original Error: Code="Failed" Message="The async operation failed." AdditionalInfo=[{"Message":"No HTTP resource was found that matches the request URI 'https://southindia.network.azure.com:30114/redacted/redacted/subscriptions/redacted/resourceGroups/web-rg/providers/Microsoft.Network/virtualNetworks/web-server-vnet/subnets/1.0.1.0/24-subnet?api-version=2019-09-01'."}]

@ghost
Copy link

ghost commented May 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_route fails if name attribute contains a slash
4 participants