Add tags to cluster node pools

[wyarde]

I'm excited to present my first attempt to contribute back to Terraform. Thanks in advance for guiding me to get this PR in good shape to get merged.

Goal of PR
Add tags to AKS nodepools

Changes

• Implemented tags for nodepools resource and datasource
• Extended some of the tests
• Updated documentation

Attention points

• Although the change itself is small, this PR ended up touching almost 1K files because of the second commit where I have added the new containerservice sdk to modules.txt (required for nodepool tags), then ran go mod vendor. Besides the new files I expected, it updated many files. Is this expected behavior? Should I approach this differently?
• I had to resolve compiler errors due to casing of Web[H]ookProfiles in azurerm/internal/services/monitor/resource_arm_monitor_metric_alert.go. Is it OK to piggy-back this fix?
• I tried to run acceptance tests, but even running just the containerservice ones takes 1+ hour. What is the recommended approach to validate and test?

[mbfrahry]

Hey @wyarde! Thanks for opening this PR! I noticed that the tags attribute is in all of the various places you're adding to in the version of the sdk we're using. Do some of them not work for you? Not upgrading the sdk would make getting this change in much easier.

[wyarde]

@mbfrahry Thank you for looking into this.

That's a great point! I missed the nuance between API version and SDK version. Indeed, I 'just' need an API version bump which fortunately drastically reduces the size of this PR 💃 .

Let me know your thoughts.

[wyarde]

@mbfrahry Just to clarify further - The current containerservice API does not support tags on nodepools. So although sdk upgrade is not needed (see my reply above), I do still need to update the API version

[katbyte]

Hey @wyarde, i hope you don't mind but i've merged master to get this ready to merge 🙂 LGTM now ✅

[ghost]

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!