New resource azurerm_policy_remediation
#5746
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| package parse | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "regexp" | ||
| "strings" | ||
| ) | ||
|
|
||
| type ManagementGroupId struct { | ||
| GroupId string | ||
| } | ||
|
|
||
| func ManagementGroupID(input string) (*ManagementGroupId, error) { | ||
| regex := regexp.MustCompile(`^/providers/[Mm]icrosoft\.[Mm]anagement/management[Gg]roups/`) | ||
| if !regex.MatchString(input) { | ||
| return nil, fmt.Errorf("Unable to parse Management Group ID %q", input) | ||
| } | ||
|
|
||
| // Split the input ID by the regex | ||
| segments := regex.Split(input, -1) | ||
| if len(segments) != 2 { | ||
| return nil, fmt.Errorf("Unable to parse Management Group ID %q: expected id to have two segments after splitting", input) | ||
| } | ||
|
|
||
| groupID := segments[1] | ||
| if groupID == "" { | ||
| return nil, fmt.Errorf("unable to parse Management Group ID %q: management group name is empty", input) | ||
| } | ||
| if segments := strings.Split(groupID, "/"); len(segments) != 1 { | ||
| return nil, fmt.Errorf("unable to parse Management Group ID %q: ID has extra segments", input) | ||
| } | ||
|
|
||
| id := ManagementGroupId{ | ||
| GroupId: groupID, | ||
| } | ||
|
|
||
| return &id, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| package parse | ||
|
|
||
| import "testing" | ||
|
|
||
| func TestManagementGroupID(t *testing.T) { | ||
| testData := []struct { | ||
| Name string | ||
| Input string | ||
| Error bool | ||
| Expected *ManagementGroupId | ||
| }{ | ||
| { | ||
| Name: "Empty", | ||
| Input: "", | ||
| Error: true, | ||
| }, | ||
| { | ||
| Name: "No Management Groups Segment", | ||
| Input: "/providers/Microsoft.Management", | ||
| Error: true, | ||
| }, | ||
| { | ||
| Name: "No Management Group ID", | ||
| Input: "/providers/Microsoft.Management/managementGroups/", | ||
| Error: true, | ||
| }, | ||
| { | ||
| Name: "Management Group ID in UUID", | ||
| Input: "/providers/Microsoft.Management/managementGroups/00000000-0000-0000-0000-000000000000", | ||
| Expected: &ManagementGroupId{ | ||
| GroupId: "00000000-0000-0000-0000-000000000000", | ||
| }, | ||
| }, | ||
| { | ||
| Name: "Management Group ID in Readable ID", | ||
| Input: "/providers/Microsoft.Management/managementGroups/myGroup", | ||
| Expected: &ManagementGroupId{ | ||
| GroupId: "myGroup", | ||
| }, | ||
| }, | ||
| { | ||
| Name: "Management Group ID in UUID with wrong casing", | ||
| Input: "/providers/microsoft.management/managementgroups/00000000-0000-0000-0000-000000000000", | ||
| Expected: &ManagementGroupId{ | ||
| GroupId: "00000000-0000-0000-0000-000000000000", | ||
| }, | ||
| }, | ||
| { | ||
| Name: "Management Group ID in Readable ID with wrong casing", | ||
| Input: "/providers/microsoft.management/managementgroups/group1", | ||
| Expected: &ManagementGroupId{ | ||
| GroupId: "group1", | ||
| }, | ||
| }, | ||
| { | ||
| Name: "Invalid Management group id", | ||
| Input: "/providers/Microsoft.Management/managementGroups/myGroup/another", | ||
| Error: true, | ||
| }, | ||
| { | ||
| Name: "Resource ID in management group", | ||
| Input: "/providers/Microsoft.Management/managementGroups/myGroup/providers/Microsoft.Authorization/policyDefinitions/def1", | ||
| Error: true, | ||
| }, | ||
| } | ||
|
|
||
| for _, v := range testData { | ||
| t.Logf("[DEBUG] Testing %q", v.Name) | ||
|
|
||
| actual, err := ManagementGroupID(v.Input) | ||
| if err != nil { | ||
| if v.Error { | ||
| continue | ||
| } | ||
|
|
||
| t.Fatalf("Expected a value but got an error: %s", err) | ||
| } | ||
|
|
||
| if actual.GroupId != v.Expected.GroupId { | ||
| t.Fatalf("Expected %q but got %q for Name", v.Expected.GroupId, actual.GroupId) | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the property is group_id but this is validating the name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here group_id means this one in its ID:
the thing in other resources' IDs at the same position would be called as a
name, for instanceAnd another reason is that if we call this
group_idin the validation function, the validation function would looks likeManagementGroupGroupIDorManagementGroupID. This would be confusing with the validation function of the real management group ID. Therefore I took this name.