Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add new Resource and Data Source for spring cloud app, deployment and Active deployment #5154

Closed
wants to merge 5 commits into from

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Dec 13, 2019

depends on #4928, the second PR of issue #4891

this PR includes changes:

  1. spring cloud app
  2. spring cloud deployment (supports uploading jar)
  3. active deployment

A spring cloud Service can contains multiple Apps, and an app can have more than 1 deployments and set active deployment (which can help for blue/green deployment).

there are several limitations of the service apis:

  1. if an app has no deployments, it can not be updated, It's always suggested creating an app along with a active deployment
  2. active deployment can not be deleted

@tombuildsstuff
Copy link
Contributor

hi @njuCZ

Thanks for this PR.

Since this is dependent/blocked on #4928 (and so we can't do much with it until that's been merged) - rather than leaving this indefinitely, for the moment I'm going to close this PR. Once #4928 has been merged we'll re-open this and take another look.

Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants