Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_sql_database - support for the extended_auditing_policy property #5049

Merged
merged 21 commits into from
Mar 16, 2020
Merged

azurerm_sql_database - support for the extended_auditing_policy property #5049

merged 21 commits into from
Mar 16, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Dec 3, 2019 •
edited
Loading

Similar to #5036
continuation of #4982
sql db auditing pass

@tombuildsstuff
Copy link
Contributor

hi @yupwei68

Thanks for this PR.

Since there's still review comments from #4982 pending (which I'm assuming you're working through) I'm going to hold off reviewing this for the moment - once those have been addressed we'll take another look through :)

Thanks!

@yupwei68 yupwei68 mentioned this pull request Dec 4, 2019
Closed
@yupwei68
Copy link
Contributor Author

yupwei68 commented Dec 4, 2019

Hi @tombuildsstuff , sorry to block you, because I think that the closed PR won't be reviewed any more. I have replied comments in #4982. Please review.

@ghost ghost removed the waiting-response label Dec 4, 2019
This was referenced Dec 4, 2019
Merged
Closed
@yupwei68
Copy link
Contributor Author

hi @tombuildsstuff , any problem?

@ghost ghost removed the waiting-response label Dec 11, 2019
@yupwei68
Copy link
Contributor Author

@tombuildsstuff @katbyte I've removed some less useful fields. Please continue reviewing.

@tombuildsstuff
Copy link
Contributor

@yupwei68 looks like this is still waiting on the changes from #4982?

@ghost ghost removed the size/XL label Feb 6, 2020
@yupwei68 yupwei68 changed the title New block blob_extended_auditing_policy in resource: resource_arm_sql_database New block blob_extended_auditing_policy in resource: resource_arm_sql_database Feb 10, 2020
@yupwei68
Copy link
Contributor Author

@tombuildsstuff I have made some updates. Please continue reviewing it and #5036

@ghost ghost removed the waiting-response label Feb 10, 2020
@WodansSon WodansSon added enhancement service/mssql Microsoft SQL Server labels Feb 15, 2020
@ghost ghost added size/XL and removed size/L labels Mar 3, 2020
@yupwei68 yupwei68 changed the title New block blob_extended_auditing_policy in resource: resource_arm_sql_database New block extended_auditing_policy in resource: resource_arm_sql_database Mar 10, 2020
@yupwei68
Copy link
Contributor Author

Hi @katbyte , auditing block in resource_arm_sql_database has been updated according to changes in PR resource_arm_sql_server. Please help to review.

@ghost ghost removed the waiting-response label Mar 10, 2020
@yupwei68 yupwei68 changed the title New block extended_auditing_policy in resource: resource_arm_sql_database Nazurerm_sql_database - support for the extended_auditing_policy property Mar 10, 2020
@yupwei68 yupwei68 changed the title Nazurerm_sql_database - support for the extended_auditing_policy property azurerm_sql_database - support for the extended_auditing_policy property Mar 10, 2020
katbyte
katbyte requested changes Mar 13, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yupwei68,

Thanks for the changes! couple minor comments on the tests and this should be ready to merge!

azurerm/internal/services/sql/tests/resource_arm_sql_database_test.go Show resolved Hide resolved
azurerm/internal/services/sql/tests/resource_arm_sql_database_test.go Show resolved Hide resolved
azurerm/internal/services/sql/tests/resource_arm_sql_database_test.go Outdated Show resolved Hide resolved
katbyte
katbyte approved these changes Mar 16, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions @yupwei68, LGTM 👍

@katbyte katbyte merged commit c9ceaa1 into hashicorp:master Mar 16, 2020
katbyte added a commit that referenced this pull request Mar 16, 2020
@katbyte
Update CHANGELOG.md to include #5049
aac1c01
@katbyte katbyte added this to the v2.2.0 milestone Mar 17, 2020
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.2.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.2.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Mar 19, 2020
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
@yupwei68 yupwei68 deleted the wyp-sqldbauditing branch July 10, 2020 02:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
documentation enhancement service/mssql Microsoft SQL Server size/XL
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yupwei68 @tombuildsstuff @katbyte @WodansSon