Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIVersion and APIVersionSetID to import #4993

Merged
merged 3 commits into from
Dec 12, 2019

Conversation

sam-cogan
Copy link
Contributor

@sam-cogan sam-cogan commented Nov 26, 2019

Adds the APIVersion and APIVersionSetID to the REST call for creating an API using an import from a file (swagger, WSDL etc.). This fixes the bug in #4985 that would result in creation failing if attempting to create more than 1 version of a single API with the same path.

Fixes #4985

@ghost ghost added the size/XS label Nov 26, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @sam-cogan

Thanks for this PR - taking a look through this is looking pretty good, if we can fix up the comments (mostly adding back in the missing links) then this otherwise LGTM 👍

Thanks!

azurerm/resource_arm_api_management_api.go Outdated Show resolved Hide resolved
@sam-cogan
Copy link
Contributor Author

@tombuildsstuff I've updated the code to move the validation earlier, but not sure what you meant by "adding back missing links"

@ghost ghost removed the waiting-response label Nov 27, 2019
@tombuildsstuff tombuildsstuff modified the milestones: v1.38.0, v1.39.0 Dec 3, 2019
@sam-cogan
Copy link
Contributor Author

@tombuildsstuff is there anything left that needs doing to get this merged?

@tombuildsstuff
Copy link
Contributor

chatting offline: this is fine, I'd confused the comment when writing the PR summary 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-12-12 at 15 28 09

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @sam-cogan

@tombuildsstuff tombuildsstuff merged commit 0f65de9 into hashicorp:master Dec 12, 2019
tombuildsstuff added a commit that referenced this pull request Dec 12, 2019
jackbatzner pushed a commit to jackbatzner/terraform-provider-azurerm that referenced this pull request Dec 13, 2019
@ghost
Copy link

ghost commented Dec 16, 2019

This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.39.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create multiple versioned APIs with Swagger
2 participants