provider: ensure all locks are done in the same order

[katbyte]

a follow up on #4501

[tombuildsstuff]

LGTM - although this wants some manual confirmation 👍

[ghost]

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

[nitzanm]

@katbyte Thanks for doing this! Looking at the code, and comparing it with my notes in #4501, I think there's still some inconsistency. Here's what I'm seeing in the code after both #4501 and this are merged:

NSG association:

1. NSG
2. Subnet
3. Vnet

Network interface:

1. NSG
2. Subnet
3. Vnet

resource_arm_firewall.go:

1. Vnet
2. Subnet

resource_arm_network_profile.go:

1. Vnet
2. Subnet

resource_arm_redis_cache.go:

1. Vnet
2. Subnet

I think NSG association and network interface are still in the opposite order than the three files you modified here. Can you take a quick look to see if I'm getting this right?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!