Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients: ensuring the user agent is set even if there's no partner id #4463

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

tombuildsstuff
Copy link
Contributor

The check for partner_id happens within the setUserAgent function
so we can instead delegate to that and ensure this is always set

which means the user agent gets set again:

2019-09-30T16:41:01.792+0200 [DEBUG] plugin.terraform-provider-azurerm: User-Agent: Go/go1.13 (amd64-darwin) go-autorest/v13.0.0 Azure-SDK-For-Go/v33.2.0 resources/2016-02-01 Terraform/0.12.8 terraform-provider-azurerm/dev

The check for `partner_id` happens within the setUserAgent function
so we can instead delegate to that and ensure this is always set
@tombuildsstuff tombuildsstuff added this to the v1.35.0 milestone Sep 30, 2019
@tombuildsstuff tombuildsstuff requested a review from a team September 30, 2019 14:41
@ghost ghost added the size/XS label Sep 30, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 00f7fc4 into master Sep 30, 2019
@tombuildsstuff tombuildsstuff deleted the b/user-agent branch September 30, 2019 18:46
tombuildsstuff added a commit that referenced this pull request Sep 30, 2019
@ghost
Copy link

ghost commented Oct 4, 2019

This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.35.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants