Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_api_management_subscription #3103

Merged
merged 4 commits into from
Mar 24, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR adds support for API Management Subscriptions, which are a part of #1177

Of particular note here is that the User ID and Product ID need to be fully qualified Resource ID's (which is what the API returns); however the API allows a short-hand too at creation time (/products/0000) - but there's validation to confirm the ID is a Resource ID since this is what's actually returned from the API.

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2019-03-22 at 11 18 54

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few little things, otherwise LGTM 🚀

azurerm/resource_arm_api_management_subscription_test.go Outdated Show resolved Hide resolved
website/docs/r/api_management_subscription.html.markdown Outdated Show resolved Hide resolved
website/docs/r/api_management_subscription.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2019-03-24 at 06 10 34

@tombuildsstuff tombuildsstuff merged commit b1421a0 into master Mar 24, 2019
@tombuildsstuff tombuildsstuff deleted the f/api-management-subscription branch March 24, 2019 06:11
tombuildsstuff added a commit that referenced this pull request Mar 24, 2019
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 23, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants