Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validations for K8s resource fields #2772

Merged
merged 7 commits into from
Jan 30, 2019
Merged

Add validations for K8s resource fields #2772

merged 7 commits into from
Jan 30, 2019

Conversation

metacpp
Copy link
Contributor

@metacpp metacpp commented Jan 26, 2019

This PR adds some validation methods for K8s resource fields.

Fixes #1405.

@ghost ghost added the size/L label Jan 26, 2019
@metacpp metacpp added this to the 2.0.0 milestone Jan 26, 2019
katbyte
katbyte requested changes Jan 26, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding some validate here @metacpp, I've left some comments inline

azurerm/helpers/validate/kubernetes.go Outdated Show resolved Hide resolved
azurerm/helpers/validate/kubernetes.go Outdated Show resolved Hide resolved
azurerm/resource_arm_kubernetes_cluster.go Outdated Show resolved Hide resolved
azurerm/resource_arm_kubernetes_cluster.go Outdated Show resolved Hide resolved
azurerm/resource_arm_kubernetes_cluster.go Outdated Show resolved Hide resolved
azurerm/resource_arm_kubernetes_cluster.go Outdated
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validate.NoEmptyStrings,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use azure.ValidateResourceID here"

Copy link
Contributor Author

@metacpp metacpp Jan 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte client_app_id is more like GUID, instead of resource ID. Shall we use UUID instead here ?

azurerm/resource_arm_kubernetes_cluster.go Outdated
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validate.NoEmptyStrings,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use azure.ValidateResourceID here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above question.

azurerm/resource_arm_kubernetes_cluster.go Outdated Show resolved Hide resolved
@ghost ghost added size/XL and removed size/L labels Jan 29, 2019
@metacpp
Copy link
Contributor Author

metacpp commented Jan 29, 2019

@katbyte Thanks for reviewing PR and providing so many useful suggestions. I've updated the PR to address most of the comments in PR.

katbyte
katbyte requested changes Jan 29, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @metacpp, i've left one comment inline and once that is addressed this PR should be good to merge

azurerm/resource_arm_kubernetes_cluster_test.go Outdated Show resolved Hide resolved
@metacpp
Copy link
Contributor Author

metacpp commented Jan 30, 2019

@katbyte I updated the PR through merging the tests into one.

@katbyte
Copy link
Collaborator

katbyte commented Jan 30, 2019

Thanks @metacpp, LGTM now 👍

@katbyte katbyte merged commit 0aedd77 into master Jan 30, 2019
@katbyte katbyte deleted the k8s_validate branch January 30, 2019 02:50
katbyte added a commit that referenced this pull request Jan 30, 2019
@katbyte
Update CHANGELOG.md to include #2772
f4ed2bb
@tombuildsstuff tombuildsstuff modified the milestones: 2.0.0, 1.22.0 Jan 30, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
@ghost ghost removed the waiting-response label Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

@JunyiYi JunyiYi Awaiting requested review from JunyiYi

@WodansSon WodansSon Awaiting requested review from WodansSon

Assignees
No one assigned
Labels
enhancement service/kubernetes-cluster size/XL
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@metacpp @katbyte @tombuildsstuff