resource azurerm_api_management add V2 SKUs

[ZsoltPath]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Adds BasicV2 and StandardV2 SKUs to azurerm_api_management resource
The new SKUs are generally available. https://azure.microsoft.com/en-us/pricing/details/api-management/

Unfortunately it breaks the sign_in and sign_up optional Developer portal settings.
I think they'll need one or two new resources to configure them separately. They aren't part of this PR.
The APIM resource is installing and working without them.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
  I couldn't run the acceptance test. I only have access to a very restricted subscription. It has a rule for RG names. I changed all of them in the tests, but then all of them failed because the subscription has an automatic deletion lock on all RGs.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_api_management - support for the BasicV2 and StandardV2 values in the sku_name property

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #25445

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[chrisyaxley]

👍

[stephybun]

To provide an update here for anyone following this issue:

• We would prefer to have this updated to the next stable version that includes the Standard V2 Skus which would be 2024-05-01, unfortunately some endpoints that we would need do not support this version yet (apis, products, backends) - the service team are expecting to deploy a fix for this in the middle of January 2025
• We're looking into whether we can update this to 2023-05-01-preview in the interim, but require feedback from MSFT whether this preview version is safe to use or could result in some breaking behaviour changes further down the line

@sinbai please provide an update here when the service team get back to you

[sinbai]

To provide an update here for anyone following this issue:

• We would prefer to have this updated to the next stable version that includes the Standard V2 Skus which would be 2024-05-01, unfortunately some endpoints that we would need do not support this version yet (apis, products, backends)
• We're looking into whether we can update this to 2023-05-01-preview in the interim, but require feedback from MSFT whether this preview version is safe to use or could result in some breaking behaviour changes further down the line

@sinbai please provide an update here when the service team get back to you

@stephybun I've pinged but no reply yet, would ping again.

[sinbai]

To provide an update here for anyone following this issue:

• We would prefer to have this updated to the next stable version that includes the Standard V2 Skus which would be 2024-05-01, unfortunately some endpoints that we would need do not support this version yet (apis, products, backends)
• We're looking into whether we can update this to 2023-05-01-preview in the interim, but require feedback from MSFT whether this preview version is safe to use or could result in some breaking behaviour changes further down the line

@sinbai please provide an update here when the service team get back to you

@stephybun I've pinged but no reply yet, would ping again.

Hi @stephybun I received a response from the service team that "please don’t rely on preview versions.".

[ZsoltPath]

To provide an update here for anyone following this issue:

• We would prefer to have this updated to the next stable version that includes the Standard V2 Skus which would be 2024-05-01, unfortunately some endpoints that we would need do not support this version yet (apis, products, backends)
• We're looking into whether we can update this to 2023-05-01-preview in the interim, but require feedback from MSFT whether this preview version is safe to use or could result in some breaking behaviour changes further down the line

@sinbai please provide an update here when the service team get back to you

@stephybun I've pinged but no reply yet, would ping again.

Hi @stephybun I received a response from the service team that "please don’t rely on preview versions.".

Hi @sinbai and @stephybun,

Is there any news about the APIs? Is MS going to make any time soon?
I know we shouldn't rely on preview versions, but what's the situation when there's no alternative? We ARE using preview SDKs in the provider when necessary.

[stephybun]

@ZsoltPath due to previous experiences with preview versions introducing sudden breaking changes and breaking user's Terraform configuration, we need to get assurances from MSFT that a preview version won't contain any potential breaking changes before we can use it.

In this particular instance we received feedback that we cannot rely on the preview version to not contain breaking changes so this is unfortunately not an option for us here.

They indicated that support for the remaining endpoints in the stable version would be added towards end of January. Given we're nearing the holiday period I don't expect this to happen anytime before then, but I will raise this internally as well to see if we can push for this to be done earlier in January.