azurerm_advisor_recommendations - Add filter_by_resource_ids and filter_by_recommendation_type_guids

[jkroepke]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Allow filter advisor recommendation by resource id and recommendation type.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

=== RUN   TestAccAdvisorRecommendationsDataSource_basic
=== PAUSE TestAccAdvisorRecommendationsDataSource_basic
=== CONT  TestAccAdvisorRecommendationsDataSource_basic
--- PASS: TestAccAdvisorRecommendationsDataSource_basic (27.54s)
=== RUN   TestAccAdvisorRecommendationsDataSource_complete
=== PAUSE TestAccAdvisorRecommendationsDataSource_complete
=== CONT  TestAccAdvisorRecommendationsDataSource_complete
--- PASS: TestAccAdvisorRecommendationsDataSource_complete (104.52s)
=== RUN   TestAccAdvisorRecommendationsDataSource_categoriesFilter
=== PAUSE TestAccAdvisorRecommendationsDataSource_categoriesFilter
=== CONT  TestAccAdvisorRecommendationsDataSource_categoriesFilter
--- PASS: TestAccAdvisorRecommendationsDataSource_categoriesFilter (28.58s)
=== RUN   TestAccAdvisorRecommendationsDataSource_resourceFilter
=== PAUSE TestAccAdvisorRecommendationsDataSource_resourceFilter
=== CONT  TestAccAdvisorRecommendationsDataSource_resourceFilter
--- PASS: TestAccAdvisorRecommendationsDataSource_resourceFilter (102.71s)
PASS

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• Data Source - azurerm_advisor_recommendations - support for filter_by_resource_ids and filter_by_recommendation_type_guids [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[katbyte]

It looks like we have a test failure------- Stdout: -------
=== RUN TestAccAdvisorRecommendationsDataSource_resourceFilter
=== PAUSE TestAccAdvisorRecommendationsDataSource_resourceFilter
=== CONT TestAccAdvisorRecommendationsDataSource_resourceFilter
testcase.go:173: Step 1/1 error: Error running pre-apply plan: exit status 1

    Error: Unsupported argument
    
      on terraform_plugin_test.tf line 40, in resource "azurerm_storage_account" "test":
      40:   enable_https_traffic_only = false
    
    An argument named "enable_https_traffic_only" is not expected here.

--- FAIL: TestAccAdvisorRecommendationsDataSource_resourceFilter (4.57s)
FAIL

[github-actions]

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!