add azurerm_iotcentral_user
#24911
add azurerm_iotcentral_user
#24911
Conversation
KenSpur
changed the title
azurerm_iotcentral_organizationazurerm_iotcentral_user
KenSpur
force-pushed
the
add-iotcentral-user
branch
from
40078fb to
067f7e4
Compare
There was a problem hiding this comment.
Thanks for the pr @KenSpur - overall looks fine but i do wonder if instead of trying to create a single resource we split this up into azurerm_iotcentral_user azurerm_iotcentral_group and azurerm_iotcentral_service_pricipal?
(or azurerm_iotcentral_user_$type if that makes more sense?)
| "role_id": { | ||
| Type: pluginsdk.TypeString, | ||
| Required: true, | ||
| }, |
There was a problem hiding this comment.
Should we be validating this?
There was a problem hiding this comment.
Replied to last comment.
| Type: pluginsdk.TypeString, | ||
| Optional: true, | ||
| ForceNew: true, | ||
| }, |
There was a problem hiding this comment.
Should we be validating this?
There was a problem hiding this comment.
Replied to last comment.
| "email": { | ||
| Type: pluginsdk.TypeString, | ||
| Optional: true, | ||
| ForceNew: true, | ||
| }, | ||
| "tenant_id": { | ||
| Type: pluginsdk.TypeString, | ||
| Optional: true, | ||
| ForceNew: true, | ||
| }, | ||
| "object_id": { |
There was a problem hiding this comment.
Should we be validating these?
There was a problem hiding this comment.
The API documentation isn't specific about these properties, not sure if it's appropriate for us to implement our own validations
#22338