Support locale in consumption budgets #23509
Conversation
github-actions
bot
added
service/consumption
state-migration
size/S
waiting-response
labels
There was a problem hiding this comment.
@stawik-mesa Thanks for opening this PR! This is mostly looking good, but we'll want to ensure that we have test coverage for this property for each of the updated resources. These can be added to the "complete" test config where one exists, or a test config where this block is already specified. Additionally, new optional properties in most cases require a default value to be specified in the schema, so that we don't incorrectly send blank values.
If you can look at adding these, I'll review again and run the tests and we should be in a good position to merge this. Please feel free to reach out if you'd like some additional pointers. Thanks!
| "locale": { | ||
| Type: pluginsdk.TypeString, | ||
| Optional: true, | ||
| ValidateFunc: validation.StringInSlice(budgets.PossibleValuesForCultureCode(), false), | ||
| }, |
There was a problem hiding this comment.
As above we will probably need a default value here.
internal/services/consumption/migration/consumption_budget_subscription.go
Outdated
Show resolved
Hide resolved
internal/services/consumption/migration/consumption_budget_subscription.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Bamford <[email protected]>
|
@manicminer Thank you for the reviews. If the default value is used, a GET request doesn't have the property so its absent. |
|
@stawik-mesa Sorry for the delay in replying, I've commented inline (above) regarding the default value. |
Co-authored-by: Tom Harvey <[email protected]>
internal/services/consumption/consumption_budget_management_group_resource.go
Show resolved
Hide resolved
|
@manicminer @tombuildsstuff Seems legit to make it computed. I have added it now. Is there anything else missing from my side? |
|
Can someone please take a look? @manicminer @tombuildsstuff ? |
|
Hi @stawik-mesa @manicminer @tombuildsstuff . |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Hi @manicminer & @tombuildsstuff any change to get this merged? Best regards |
|
Hey @stawik-mesa - i was looking at this today and while the PR looks good it appears the test are all failing now with: should we be using en-us instead of en-US? |
internal/services/consumption/consumption_budget_subscription_resource_test.go
Outdated
Show resolved
Hide resolved
Hi @katbyte, I have changed it to en-us. Can you please run the workflows again to check if all issues are resolved now? Thank you ;) |
|
That does not appear to fix it :( |
@stawik-mesa possibly forgotten to adjust within internal/services/consumption/consumption_budget_resource_group_resource_test.go |
|
@AndreasAugustin @katbyte Can you check again. hopefully it's fixed now. |
@katbyte @AndreasAugustin @manicminer is there any chance to get this merged? Thank you ;) |
Hi @stawik-mesa this is just f.y.i.: sorry I cannot help. Am not within the project :) I just tried to help because I also want to have this merged ASAP (because of #25619 ). |
There was a problem hiding this comment.
unfortunately this still appears to cause all tests to fail:
testcase.go:130: Step 1/6 error: Error running apply: exit status 1|n |n Error: creating Scoped Budget (Scope: "/subscriptions/*******"|n Budget Name: "acctestconsumptionbudgetsubscription-240826083653725491"): unexpected status 400 (400 Bad Request) with error: 400: Unsupported locale parameter . Try en-us to set language as English for the alerts or visit https://go.microsoft.com/fwlink/?linkid=2139450 to see all supported locales
| "locale": { | ||
| Type: pluginsdk.TypeString, | ||
| Optional: true, | ||
| Computed: true, // TODO: make this required in 4.0 |
There was a problem hiding this comment.
we will not be accepting any more todo next major version comments like this post 4.0. We should have/be adding the 5.0 flag in soon which can be used to automatically flip this when 5.0 is released
|
This PR is being labeled as "stale" because it has not been updated for 30 or more days. If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone. If you need some help completing this PR, please leave a comment letting us know. Thank you! |
|
This PR is being labeled as "stale" because it has not been updated for 30 or more days. If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone. If you need some help completing this PR, please leave a comment letting us know. Thank you! |
Resolves #22025