Skip to content

azurerm_postgresql_flexible_server - fix identity#21979

Merged
stephybun merged 1 commit into
hashicorp:mainfrom
myc2h6o:postgresql_flexi_identity
Jun 6, 2023
Merged

azurerm_postgresql_flexible_server - fix identity#21979
stephybun merged 1 commit into
hashicorp:mainfrom
myc2h6o:postgresql_flexi_identity

Conversation

@myc2h6o

@myc2h6o myc2h6o commented May 31, 2023

Copy link
Copy Markdown
Contributor

@tombuildsstuff

Copy link
Copy Markdown
Contributor

hi @myc2h6o

Thanks for this PR

There's an issue on the Pandora repository (hashicorp/pandora#2575) which @stephybun is taking a look into, which would ensure that this is accurately picked up as the default User Assigned Identity type, rather than this custom type - as such we'll want that fixed here to ensure this remains consistent, so I'm going to assign this PR to @stephybun so that once is fixed upstream, we can take a look into fixing.

Thanks!

@tombuildsstuff tombuildsstuff added the upstream/pandora This issue/PR has a dependency on an issue in `github.com/hashicorp/pandora` label May 31, 2023
@myc2h6o myc2h6o force-pushed the postgresql_flexi_identity branch from 506740b to 3c61dee Compare June 6, 2023 14:21
@myc2h6o

myc2h6o commented Jun 6, 2023

Copy link
Copy Markdown
Contributor Author

sdk version has been upgraded by #22053, I've rebased the branch.

@stephybun stephybun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @myc2h6o LGTM 👍

@stephybun stephybun merged commit e930684 into hashicorp:main Jun 6, 2023
@github-actions github-actions Bot added this to the v3.60.0 milestone Jun 6, 2023
@myc2h6o myc2h6o deleted the postgresql_flexi_identity branch June 6, 2023 14:52
@github-actions

Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation service/postgresql size/XS upstream/pandora This issue/PR has a dependency on an issue in `github.com/hashicorp/pandora`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azurerm_postgresql_flexible_server: correct identity expansion as described in the document

3 participants