azurerm_key_vault - support for Virtual Network Rules
#2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deletion Fixes #1491 ``` $ acctests azurerm TestAccAzureRMStorageAccount_networkRules === RUN TestAccAzureRMStorageAccount_networkRules --- PASS: TestAccAzureRMStorageAccount_networkRules (242.68s) === RUN TestAccAzureRMStorageAccount_networkRulesDeleted --- PASS: TestAccAzureRMStorageAccount_networkRulesDeleted (193.87s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 437.440s ```
|
Key Vault Resource tests pass:
Storage Tests pass (ignoring some known test failures):
|
``` $ acctests azurerm TestAccDataSourceAzureRMKeyVault_networkAcls === RUN TestAccDataSourceAzureRMKeyVault_networkAcls --- PASS: TestAccDataSourceAzureRMKeyVault_networkAcls (310.74s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 311.651s ```
|
Data Source tests pass:
|
katbyte
approved these changes
Oct 5, 2018
There was a problem hiding this comment.
LGTM @tombuildsstuff 👍
Left one minor comment about comments but its no blocker
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does four things:
2018-02-14of the Key Vault API'sazurerm_key_vault- exposing thenetwork_aclsblockazurerm_key_vault- adding support for settingnetwork_acls(including Virtual Network Rules)azurerm_storage_account- locking on the Virtual Network name when deleting the storage accountThis should fix #1491 - but I've been unable to reproduce it