Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/application_gateway: clarify default value of require_sni in an http_listener #1636

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

Supermathie
Copy link
Contributor

Is there any reason we can't just make the default for require_sni to be true when the listener is HTTPS?

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this 👍

@tombuildsstuff
Copy link
Contributor

@Supermathie

Thanks for this PR :)

Is there any reason we can't just make the default for require_sni to be true when the listener is HTTPS?

In general we either have a default value or make it required, rather than changing the value dynamically, but possibly in the future - unfortunately either way we're currently blocked on any enhancements to Application Gateway because of #1576.

In the interim we're planning on rewriting the documentation for the Application Gateway resource in the near future to bring it into line with the other resources too, so that we can make this clearer.

Thanks!

@tombuildsstuff tombuildsstuff merged commit 62b5c7a into hashicorp:master Jul 24, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants