Remove tags validate in preConfig of TestAccAzureRMKeyVault_update #1534
Conversation
There was a problem hiding this comment.
hi @lrxtom2
Thanks for this PR. Taking a look at this I think it'd be better to update this assertion to check that there's no tags in the Pre phrase, rather than removing it (which doesn't allow us to assert that this has changed)
Thanks!
| @@ -125,7 +125,6 @@ func TestAccAzureRMKeyVault_update(t *testing.T) { | |||
| testCheckAzureRMKeyVaultExists(resourceName), | |||
| resource.TestCheckResourceAttr(resourceName, "access_policy.0.key_permissions.0", "create"), | |||
| resource.TestCheckResourceAttr(resourceName, "access_policy.0.secret_permissions.0", "set"), | |||
| resource.TestCheckResourceAttr(resourceName, "tags.environment", "Production"), | |||
There was a problem hiding this comment.
can we add this back in but instead check that tags.% is equal to 0 which will ensure there's no tags in the Pre phase
|
Thanks for @tombuildsstuff |
* api-management: Updating to include hashicorp#1565 resource/servicebus_subscription_rule: Fix the correlation_filter optional values (hashicorp#1565) Updating to include hashicorp#1563 resouce/app_insights: Allow different application_type deployments (hashicorp#1563) VMSS: changed sku property from a set to list Update CHANGELOG.md to include hashicorp#1552 Renamed azurerm_azuread_application.html.markdown to azuread_application.html.markdown New Data Source: `azurerm_azuread_application` VMSS: Updating the code samples to be valid. Fixes hashicorp#1539 (hashicorp#1549) Creation Data -> Creation Date (hashicorp#1548) Updating to include hashicorp#1546 Workaround upstream issue in creating azureEndpoints in traffic manager (hashicorp#1546) Cleanup after v1.9.0 release v1.9.0 Updating to include hashicorp#1269 New Resource: `azurerm_azuread_application` (hashicorp#1269) Remove tags validate in preConfig of TestAccAzureRMKeyVault_update (hashicorp#1534) Updating to include hashicorp#1535 `azurerm_key_vault_key` - handling the parent Key Vault being deleted (hashicorp#1535)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
There are no tags block in preConfig method, so we should remove validate tags in the fitst step of this test: TestAccAzureRMKeyVault_update