Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_mysql_flexible_database - New resource #14285

Merged
merged 6 commits into from
Nov 26, 2021
Merged

azurerm_mysql_flexible_database - New resource #14285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
afe60e8
`azurerm_mysql_flexible_database` - New resource
Nov 21, 2021
760c999
Fix Exists()
Nov 21, 2021
3d40873
Fix ImporterValidation
Nov 21, 2021
2ba83f1
Fix terrafmt
Nov 21, 2021
ab9b5f0
Fix ImportAsExistError
Nov 21, 2021
8e66134
Docs
Nov 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/services/mysql/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ type Client struct {
ConfigurationsClient *mysql.ConfigurationsClient
DatabasesClient *mysql.DatabasesClient
FirewallRulesClient *mysql.FirewallRulesClient
FlexibleDatabasesClient *mysqlflexibleservers.DatabasesClient
FlexibleServerConfigurationsClient *mysqlflexibleservers.ConfigurationsClient
FlexibleServerClient *mysqlflexibleservers.ServersClient
FlexibleServerFirewallRulesClient *mysqlflexibleservers.FirewallRulesClient
Expand All @@ -30,6 +31,9 @@ func NewClient(o *common.ClientOptions) *Client {
FirewallRulesClient := mysql.NewFirewallRulesClientWithBaseURI(o.ResourceManagerEndpoint, o.SubscriptionId)
o.ConfigureClient(&FirewallRulesClient.Client, o.ResourceManagerAuthorizer)

flexibleDatabasesClient := mysqlflexibleservers.NewDatabasesClientWithBaseURI(o.ResourceManagerEndpoint, o.SubscriptionId)
o.ConfigureClient(&flexibleDatabasesClient.Client, o.ResourceManagerAuthorizer)

flexibleServerClient := mysqlflexibleservers.NewServersClientWithBaseURI(o.ResourceManagerEndpoint, o.SubscriptionId)
o.ConfigureClient(&flexibleServerClient.Client, o.ResourceManagerAuthorizer)

Expand Down Expand Up @@ -58,6 +62,7 @@ func NewClient(o *common.ClientOptions) *Client {
ConfigurationsClient: &ConfigurationsClient,
DatabasesClient: &DatabasesClient,
FirewallRulesClient: &FirewallRulesClient,
FlexibleDatabasesClient: &flexibleDatabasesClient,
FlexibleServerClient: &flexibleServerClient,
FlexibleServerFirewallRulesClient: &flexibleServerFirewallRulesClient,
FlexibleServerConfigurationsClient: &flexibleServerConfigurationsClient,
Expand Down
162 changes: 162 additions & 0 deletions internal/services/mysql/mysql_flexible_database_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,162 @@
package mysql

import (
"fmt"
"log"
"time"

"github.com/Azure/azure-sdk-for-go/services/mysql/mgmt/2021-05-01/mysqlflexibleservers"
"github.com/hashicorp/terraform-provider-azurerm/helpers/azure"
"github.com/hashicorp/terraform-provider-azurerm/helpers/tf"
"github.com/hashicorp/terraform-provider-azurerm/internal/clients"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/mysql/parse"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/mysql/validate"
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk"
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/suppress"
"github.com/hashicorp/terraform-provider-azurerm/internal/timeouts"
"github.com/hashicorp/terraform-provider-azurerm/utils"
)

func resourceMySqlFlexibleDatabase() *pluginsdk.Resource {
return &pluginsdk.Resource{
Create: resourceMySqlFlexibleDatabaseCreate,
Read: resourceMySqlFlexibleDatabaseRead,
Delete: resourceMySqlFlexibleDatabaseDelete,
Importer: pluginsdk.ImporterValidatingResourceId(func(id string) error {
_, err := parse.FlexibleDatabaseID(id)
return err
}),

Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(60 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(60 * time.Minute),
Delete: pluginsdk.DefaultTimeout(60 * time.Minute),
},

Schema: map[string]*pluginsdk.Schema{
"name": {
Type: pluginsdk.TypeString,
Required: true,
ForceNew: true,
},

"resource_group_name": azure.SchemaResourceGroupName(),

"server_name": {
Type: pluginsdk.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validate.ServerName,
},

"charset": {
Type: pluginsdk.TypeString,
Required: true,
DiffSuppressFunc: suppress.CaseDifference,
ForceNew: true,
},

"collation": {
Type: pluginsdk.TypeString,
Required: true,
ForceNew: true,
},
},
}
}

func resourceMySqlFlexibleDatabaseCreate(d *pluginsdk.ResourceData, meta interface{}) error {
client := meta.(*clients.Client).MySQL.FlexibleDatabasesClient
subscriptionId := meta.(*clients.Client).Account.SubscriptionId
ctx, cancel := timeouts.ForCreate(meta.(*clients.Client).StopContext, d)
defer cancel()

log.Printf("[INFO] preparing arguments for AzureRM MySQL Database creation.")

charset := d.Get("charset").(string)
collation := d.Get("collation").(string)

id := parse.NewFlexibleDatabaseID(subscriptionId, d.Get("resource_group_name").(string), d.Get("server_name").(string), d.Get("name").(string))
if d.IsNewResource() {
existing, err := client.Get(ctx, id.ResourceGroup, id.FlexibleServerName, id.DatabaseName)
if err != nil {
if !utils.ResponseWasNotFound(existing.Response) {
return fmt.Errorf("checking for presence of existing %s: %v", id, err)
}
}

if !utils.ResponseWasNotFound(existing.Response) {
return tf.ImportAsExistsError("azurerm_mysql_flexible_database", id.ID())
}
}

properties := mysqlflexibleservers.Database{
DatabaseProperties: &mysqlflexibleservers.DatabaseProperties{
Charset: utils.String(charset),
Collation: utils.String(collation),
},
}

future, err := client.CreateOrUpdate(ctx, id.ResourceGroup, id.FlexibleServerName, id.DatabaseName, properties)
if err != nil {
return fmt.Errorf("creating %s: %v", id, err)
}
if err = future.WaitForCompletionRef(ctx, client.Client); err != nil {
return fmt.Errorf("waiting on creation of %s: %v", id, err)
}

d.SetId(id.ID())
return resourceMySqlFlexibleDatabaseRead(d, meta)
}

func resourceMySqlFlexibleDatabaseRead(d *pluginsdk.ResourceData, meta interface{}) error {
client := meta.(*clients.Client).MySQL.FlexibleDatabasesClient
ctx, cancel := timeouts.ForRead(meta.(*clients.Client).StopContext, d)
defer cancel()

id, err := parse.FlexibleDatabaseID(d.Id())
if err != nil {
return err
}

resp, err := client.Get(ctx, id.ResourceGroup, id.FlexibleServerName, id.DatabaseName)
if err != nil {
if utils.ResponseWasNotFound(resp.Response) {
d.SetId("")
return nil
}
return fmt.Errorf("retrieving %s: %+v", *id, err)
}

d.Set("name", id.DatabaseName)
d.Set("server_name", id.FlexibleServerName)
d.Set("resource_group_name", id.ResourceGroup)

d.Set("charset", resp.Charset)
d.Set("collation", resp.Collation)

return nil
}

func resourceMySqlFlexibleDatabaseDelete(d *pluginsdk.ResourceData, meta interface{}) error {
client := meta.(*clients.Client).MySQL.FlexibleDatabasesClient
ctx, cancel := timeouts.ForDelete(meta.(*clients.Client).StopContext, d)
defer cancel()

id, err := parse.FlexibleDatabaseID(d.Id())
if err != nil {
return err
}

future, err := client.Delete(ctx, id.ResourceGroup, id.FlexibleServerName, id.DatabaseName)
if err != nil {
return fmt.Errorf("deleting %s: %+v", *id, err)
}

if err := future.WaitForCompletionRef(ctx, client.Client); err != nil {
return fmt.Errorf("waiting for deletion of %s: %+v", *id, err)
}

return nil
}
197 changes: 197 additions & 0 deletions internal/services/mysql/mysql_flexible_database_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,197 @@
package mysql_test

import (
"context"
"fmt"
"testing"

"github.com/hashicorp/terraform-provider-azurerm/internal/acceptance"
"github.com/hashicorp/terraform-provider-azurerm/internal/acceptance/check"
"github.com/hashicorp/terraform-provider-azurerm/internal/clients"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/mysql/parse"
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk"
"github.com/hashicorp/terraform-provider-azurerm/utils"
)

type MySQLFlexibleDatabaseResource struct {
}

func TestAccMySQLFlexibleDatabase_basic(t *testing.T) {
data := acceptance.BuildTestData(t, "azurerm_mysql_flexible_database", "test")
r := MySQLFlexibleDatabaseResource{}

data.ResourceTest(t, r, []acceptance.TestStep{
{
Config: r.basic(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
),
},
data.ImportStep(),
})
}

func TestAccMySQLFlexibleDatabase_requiresImport(t *testing.T) {
data := acceptance.BuildTestData(t, "azurerm_mysql_flexible_database", "test")
r := MySQLFlexibleDatabaseResource{}

data.ResourceTest(t, r, []acceptance.TestStep{
{
Config: r.basic(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
),
},
{
Config: r.requiresImport(data),
ExpectError: acceptance.RequiresImportError("azurerm_mysql_flexible_database"),
},
})
}

func TestAccMySQLFlexibleDatabase_charsetUppercase(t *testing.T) {
data := acceptance.BuildTestData(t, "azurerm_mysql_flexible_database", "test")
r := MySQLFlexibleDatabaseResource{}

data.ResourceTest(t, r, []acceptance.TestStep{
{
Config: r.charsetUppercase(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("charset").HasValue("utf8"),
),
},
data.ImportStep(),
})
}

func TestAccMySQLFlexibleDatabase_charsetMixedcase(t *testing.T) {
data := acceptance.BuildTestData(t, "azurerm_mysql_flexible_database", "test")
r := MySQLFlexibleDatabaseResource{}

data.ResourceTest(t, r, []acceptance.TestStep{
{
Config: r.charsetMixedcase(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("charset").HasValue("utf8"),
),
},
data.ImportStep(),
})
}

func (r MySQLFlexibleDatabaseResource) Exists(ctx context.Context, clients *clients.Client, state *pluginsdk.InstanceState) (*bool, error) {
id, err := parse.FlexibleDatabaseID(state.ID)
if err != nil {
return nil, err
}

resp, err := clients.MySQL.FlexibleDatabasesClient.Get(ctx, id.ResourceGroup, id.FlexibleServerName, id.DatabaseName)
if err != nil {
return nil, err
}

return utils.Bool(resp.ID != nil), nil
}

func (MySQLFlexibleDatabaseResource) basic(data acceptance.TestData) string {
return fmt.Sprintf(`
provider "azurerm" {
features {}
}

resource "azurerm_resource_group" "test" {
name = "acctestRG-%d"
location = "%s"
}
resource "azurerm_mysql_flexible_server" "test" {
name = "acctest-fs-%d"
resource_group_name = azurerm_resource_group.test.name
location = azurerm_resource_group.test.location
administrator_login = "adminTerraform"
administrator_password = "QAZwsx123"
sku_name = "B_Standard_B1s"
}

resource "azurerm_mysql_flexible_database" "test" {
name = "acctestdb_%d"
resource_group_name = azurerm_resource_group.test.name
server_name = azurerm_mysql_flexible_server.test.name
charset = "utf8"
collation = "utf8_unicode_ci"
}
`, data.RandomInteger, data.Locations.Primary, data.RandomInteger, data.RandomInteger)
}

func (r MySQLFlexibleDatabaseResource) requiresImport(data acceptance.TestData) string {
return fmt.Sprintf(`
%s

resource "azurerm_mysql_flexible_database" "import" {
name = azurerm_mysql_flexible_database.test.name
resource_group_name = azurerm_mysql_flexible_database.test.resource_group_name
server_name = azurerm_mysql_flexible_database.test.server_name
charset = azurerm_mysql_flexible_database.test.charset
collation = azurerm_mysql_flexible_database.test.collation
}
`, r.basic(data))
}

func (MySQLFlexibleDatabaseResource) charsetUppercase(data acceptance.TestData) string {
return fmt.Sprintf(`
provider "azurerm" {
features {}
}

resource "azurerm_resource_group" "test" {
name = "acctestRG-%d"
location = "%s"
}
resource "azurerm_mysql_flexible_server" "test" {
name = "acctest-fs-%d"
resource_group_name = azurerm_resource_group.test.name
location = azurerm_resource_group.test.location
administrator_login = "adminTerraform"
administrator_password = "QAZwsx123"
sku_name = "B_Standard_B1s"
}

resource "azurerm_mysql_flexible_database" "test" {
name = "acctestdb_%d"
resource_group_name = azurerm_resource_group.test.name
server_name = azurerm_mysql_flexible_server.test.name
charset = "UTF8"
collation = "utf8_unicode_ci"
}
`, data.RandomInteger, data.Locations.Primary, data.RandomInteger, data.RandomInteger)
}

func (MySQLFlexibleDatabaseResource) charsetMixedcase(data acceptance.TestData) string {
return fmt.Sprintf(`
provider "azurerm" {
features {}
}

resource "azurerm_resource_group" "test" {
name = "acctestRG-%d"
location = "%s"
}
resource "azurerm_mysql_flexible_server" "test" {
name = "acctest-fs-%d"
resource_group_name = azurerm_resource_group.test.name
location = azurerm_resource_group.test.location
administrator_login = "adminTerraform"
administrator_password = "QAZwsx123"
sku_name = "B_Standard_B1s"
}

resource "azurerm_mysql_flexible_database" "test" {
name = "acctestdb_%d"
resource_group_name = azurerm_resource_group.test.name
server_name = azurerm_mysql_flexible_server.test.name
charset = "Utf8"
collation = "utf8_unicode_ci"
}
`, data.RandomInteger, data.Locations.Primary, data.RandomInteger, data.RandomInteger)
}
Loading