r\purview_account_resource: Deprecate sku_name property
#13897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myc2h6o
force-pushed
the
purview_sku_deprecate
branch
from
fb3d94b
to
92187dc
Compare
|
This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sku property of Purview Account can only be updated through a support ticket now, and has been removed from the request body when creating the resource. Since it's no longer managed by api, and the value can only be changed outside terraform, i'm considering removing it. In order to avoid breaking change, I'm updating it from
RequiredtoOptional+Deprecated.Doc and issue:
https://docs.microsoft.com/en-us/azure/purview/concept-elastic-data-map#request-capacity
[API Regression] [Purview] Accounts Sku Capacity is always reset to 1 Azure/azure-rest-api-specs#15675
Test result:
$ make acctests SERVICE='purview' TESTARGS='-run=Test' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/purview -run=Test -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccPurviewAccount_basic
=== PAUSE TestAccPurviewAccount_basic
=== RUN TestAccPurviewAccount_requiresImport
=== PAUSE TestAccPurviewAccount_requiresImport
=== CONT TestAccPurviewAccount_basic
=== CONT TestAccPurviewAccount_requiresImport
--- PASS: TestAccPurviewAccount_basic (657.38s)
--- PASS: TestAccPurviewAccount_requiresImport (683.11s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/purview 683.774s