azurerm_synapse_workspace - support linking_allowed_for_aad_tenant_ids, compute_subnet_id, public_network_access_enabled, purview_id,last_commit_id

[ms-henglu]

[ms-henglu]

@katbyte , Hi, updated, please take another look, thanks!

[katbyte]

we're going to need to fix these errors first:

------- Stdout: -------
=== RUN   TestAccPurviewAccount_basic
=== PAUSE TestAccPurviewAccount_basic
=== CONT  TestAccPurviewAccount_basic
    testcase.go:108: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # azurerm_purview_account.test will be updated in-place
          ~ resource "azurerm_purview_account" "test" {
                id                                               = "/subscriptions/*******/resourceGroups/acctestRG-purview-211025170209590716/providers/Microsoft.Purview/accounts/acctestsw211025170209590716"
                name                                             = "acctestsw211025170209590716"
              ~ sku_name                                         = "Standard_1" -> "Standard_4"
                # (9 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccPurviewAccount_basic (432.11s)
FAIL

[ms-henglu]

@katbyte , thanks! I've fixed it.

[katbyte]

build is failing:

[Step 4/5] # github.com/hashicorp/terraform-provider-azurerm/internal/services/mysql
[05:04:20]	[Step 4/5] ../mysql/mysql_flexible_server_configuration_resource.go:79:79: cannot use properties (type "github.com/Azure/azure-sdk-for-go/services/preview/mysql/mgmt/2021-05-01-preview/mysqlflexibleservers".Configuration) as type "github.com/Azure/azure-sdk-for-go/services/mysql/mgmt/2021-05-01/mysqlflexibleservers".Configuration in argument to client.Update
[05:04:20]	[Step 4/5] ../mysql/mysql_flexible_server_configuration_resource.go:147:79: cannot use properties (type "github.com/Azure/azure-sdk-for-go/services/preview/mysql/mgmt/2021-05-01-preview/mysqlflexibleservers".Configuration) as type "github.com/Azure/azure-sdk-for-go/services/mysql/mgmt/2021-05-01/mysqlflexibleservers".Configuration in argument to client.Update
[05:05:17]	[Step 4/5] Process exited with code 2

[ms-henglu]

@katbyte , the building failure is fixed, Please take another look, thanks!

[katbyte]

Thanks @ms-henglu - LGTM now 🍔

[github-actions]

This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.