Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_server: Support for azuread_authentication_only #13754

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Oct 15, 2021

Fixes #12965
Fixes half of #12252, azurerm_sql_active_directory_administrator is out of scope of this PR as this also requires an update of the API version

Acceptance Test

❯ go install && make acctests SERVICE='mssql' TESTARGS='-run=TestAccMsSqlServer_azureadAdmin'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/mssql -run=TestAccMsSqlServer_azureadAdmin -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMsSqlServer_azureadAdmin
=== PAUSE TestAccMsSqlServer_azureadAdmin
=== CONT  TestAccMsSqlServer_azureadAdmin
--- PASS: TestAccMsSqlServer_azureadAdmin (1044.36s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mssql        1046.330s

@aristosvo aristosvo force-pushed the mssql/azuread_only_authentication branch from f15c76e to 3d05f49 Compare October 15, 2021 15:02
@aristosvo aristosvo force-pushed the mssql/azuread_only_authentication branch 2 times, most recently from a85f6b2 to 2cb7c1a Compare October 15, 2021 15:12
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - aside from one comment on the property name this looks good!

internal/services/mssql/mssql_server_resource.go Outdated Show resolved Hide resolved
@katbyte katbyte added enhancement service/mssql Microsoft SQL Server labels Oct 15, 2021
@aristosvo aristosvo changed the title azurerm_mssql_server: Support for azuread_only_authentication azurerm_mssql_server: Support for azuread_authentication_only Oct 15, 2021
@aristosvo
Copy link
Collaborator Author

It would be easiest if #13753 was merged first, these PRs conflict with each other. I'll rebase it as soon it's merged.

@aristosvo aristosvo force-pushed the mssql/azuread_only_authentication branch from 6870e6b to c6ed8e6 Compare October 21, 2021 09:32
@aristosvo
Copy link
Collaborator Author

@katbyte Rebase executed, specific test passing:

❯ go install && make acctests SERVICE='mssql' TESTARGS='-run=TestAccMsSqlServer_azureadAdmin'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/mssql -run=TestAccMsSqlServer_azureadAdmin -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMsSqlServer_azureadAdmin
=== PAUSE TestAccMsSqlServer_azureadAdmin
=== RUN   TestAccMsSqlServer_azureadAdminUpdate
=== PAUSE TestAccMsSqlServer_azureadAdminUpdate
=== CONT  TestAccMsSqlServer_azureadAdmin
=== CONT  TestAccMsSqlServer_azureadAdminUpdate
--- PASS: TestAccMsSqlServer_azureadAdmin (605.04s)
--- PASS: TestAccMsSqlServer_azureadAdminUpdate (968.51s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mssql 970.095s

@katbyte katbyte added this to the v2.82.0 milestone Oct 21, 2021
@katbyte katbyte merged commit 8f2cba1 into hashicorp:main Oct 21, 2021
katbyte added a commit that referenced this pull request Oct 21, 2021
@github-actions
Copy link

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/mssql_server: support for azuread_only_authentication
2 participants