Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - kube_config and kube_admin_config blocks can now be marked entirely as Sensitive via environment variable. #13732

Merged
merged 5 commits into from
Oct 14, 2021

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Oct 14, 2021

Can now mark the whole of kube_config and kube_admin_config as sensitive by setting the environment variable ARM_AKS_KUBE_CONFIGS_SENSITIVE to true.

(workaround for #4105)

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥫

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments but otherwise 👍

@github-actions github-actions bot added size/S and removed size/XS labels Oct 14, 2021
@github-actions github-actions bot added size/M and removed size/S labels Oct 14, 2021
@github-actions github-actions bot added size/L and removed size/M labels Oct 14, 2021
@jackofallops jackofallops changed the title azurerm_kubernetes_cluster - kube_config and kube_admin_config blocks are now Sentitive azurerm_kubernetes_cluster - kube_config and kube_admin_config blocks can now be marked entirely as Sentitive via environment variable. Oct 14, 2021
@jackofallops jackofallops changed the title azurerm_kubernetes_cluster - kube_config and kube_admin_config blocks can now be marked entirely as Sentitive via environment variable. azurerm_kubernetes_cluster - kube_config and kube_admin_config blocks can now be marked entirely as Sensitive via environment variable. Oct 14, 2021
@katbyte katbyte linked an issue Oct 14, 2021 that may be closed by this pull request
@katbyte katbyte merged commit 8309d17 into main Oct 14, 2021
@katbyte katbyte deleted the f/aks-sensitive-blocks branch October 14, 2021 22:06
katbyte added a commit that referenced this pull request Oct 14, 2021
@github-actions
Copy link

This functionality has been released in v2.81.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants