Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_integration_runtime_azure - support AutoResolve for the location property #13731

Merged

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Oct 14, 2021

To address issue #13730

After using AutoResolve location, there's only one auto resolve integration runtime.
image

tests
image

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ms-henglu

Thanks for this PR.

Taking a look through whilst this is one approach to solving this issue - unfortunately this means this value would be valid for all resources (when it's not as far as I can tell?) - as such can we instead update the validation for this specific field instead?

Thanks!

internal/location/validation.go Outdated Show resolved Hide resolved
@ms-henglu ms-henglu force-pushed the issue-13730-support-autoresolve-in-df-ir branch from 99d97b2 to c097d0a Compare October 15, 2021 01:57
@ms-henglu
Copy link
Contributor Author

Hi @tombuildsstuff , thanks for code review.

I've updated it as your suggestions. Please take another look, thanks!

@ms-henglu ms-henglu force-pushed the issue-13730-support-autoresolve-in-df-ir branch from c097d0a to 4004ea7 Compare October 15, 2021 02:04
@ms-henglu ms-henglu force-pushed the issue-13730-support-autoresolve-in-df-ir branch from 4004ea7 to ca2329d Compare October 18, 2021 02:17
@katbyte katbyte added this to the v2.82.0 milestone Oct 19, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we update the docs please @ms-henglu ?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - LGTM 🍰

@katbyte katbyte changed the title support AutoResolve in location azurerm_data_factory_integration_runtime_azure - support AutoResolve for the location property Oct 21, 2021
@katbyte katbyte merged commit deccc09 into hashicorp:main Oct 21, 2021
katbyte added a commit that referenced this pull request Oct 21, 2021
@github-actions
Copy link

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants