Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to v58 of Azure SDK for Go #13608

Closed

Conversation

dylanmorley
Copy link
Contributor

@dylanmorley dylanmorley marked this pull request as draft October 4, 2021 13:55
@aristosvo
Copy link
Collaborator

@dylanmorley If you want some help, I've a bit of time on my hands and waiting on the same thing.

Let me know!

@dylanmorley dylanmorley closed this Oct 4, 2021
@dylanmorley dylanmorley deleted the feature/bump-go-version branch October 4, 2021 15:31
@dylanmorley
Copy link
Contributor Author

dylanmorley commented Oct 4, 2021

Breaking changes in compute package needs fixing - will address first (thought I'd checked if impacted, but obviously not!)

As described in the release notes, various constants are deprecated from package mgmt/2020-12-01/compute, which will impact a number of resources

@aristosvo
Copy link
Collaborator

aristosvo commented Oct 4, 2021

@dylanmorley Are the constants changed or only the Golang Enum names? It seemed to me the latter was the case, in that case it is not breaking, right?

Do you have a specific breaking resource? I've resolved the enum changes in https://github.com/aristosvo/terraform-provider-azurerm/tree/feature/58

@dylanmorley
Copy link
Contributor Author

@aristosvo yes, should have been clearer - just the constant changes (I meant breaking as not a straight upgrade -> compile -> done, needed the changes done on your branch)

Looks like you're pretty much there, so will leave a PR to you :)

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants