temp fix for synapse firewall resource

[ms-henglu]

To address issue: #13510

[tombuildsstuff]

hi @ms-henglu

Thanks for this PR.

Unfortunately this isn't guaranteed to be available within a minute (even if it responds that way at the moment) - as such we can't ship this with a Sleep here - can we poll on something else?

Thanks!

[owenfarrell]

@tombuildsstuff - Sadly, I think the answer is "no". The existing implementation runs a Get immediately following the call to CreateOrUpdate.

But I think that means the 5-minute delay cited in the Azure documentation is on Microsoft's side of the PaaS. 😔

Short of injecting a Sleep in the resource (which, I agree, doesn't feel right), I think chaining a time_sleep resource is the only safe bet here.

EDIT: Disregard the above... no sooner did I write this that I see ProvisioningState on the firewall rules response.

Of note, I ran in to this same issue when running some recent acceptance tests. So I think "mocking" up the delay as part of a PreConfig might be a need in some of the Synapse tests.

[ms-henglu]

Hi @tombuildsstuff , @owenfarrell , thanks for checking this PR.

Unfortunately this isn't guaranteed to be available within a minute (even if it responds that way at the moment)

Actually I've checked with service team, the delay is 1 minute. But I agree that this is not a good way to fix it.

So here's another solution. When IP is in the firewall ip range, we call GetWorkspace API to check whether firewall changes are taking effect. This is the recommended solution by service team.

[tombuildsstuff]

hi @ms-henglu

Thanks for pushing those changes and checking with the service team - however this approach introduces a dependency on a third-party web service which we also can't ship here - instead whilst I'd like to thank you for this contribution I'm going to close this in favour of #13525 which fixes this in a different manner.

Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.