Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_sql_server: Add threat_detection_policy argument #13048

Merged
merged 3 commits into from
Aug 19, 2021
Merged

azurerm_sql_server: Add threat_detection_policy argument #13048

merged 3 commits into from
Aug 19, 2021

Conversation

favoretti
Copy link
Collaborator 

$ TF_ACC=1 go test -v ./internal/services/sql -timeout=1000m -run='TestAccSqlServer_threatDetectionPolicy'
=== RUN   TestAccSqlServer_threatDetectionPolicy
=== PAUSE TestAccSqlServer_threatDetectionPolicy
=== CONT  TestAccSqlServer_threatDetectionPolicy
--- PASS: TestAccSqlServer_threatDetectionPolicy (316.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/sql	318.103s

Fixes #1484

@favoretti
azurerm_sql_server: Add threat_detection_policy argument
ddcafdb 
```
$ TF_ACC=1 go test -v ./internal/services/sql -timeout=1000m -run='TestAccSqlServer_threatDetectionPolicy'
=== RUN   TestAccSqlServer_threatDetectionPolicy
=== PAUSE TestAccSqlServer_threatDetectionPolicy
=== CONT  TestAccSqlServer_threatDetectionPolicy
--- PASS: TestAccSqlServer_threatDetectionPolicy (316.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/sql	318.103s
```

Fixes hashicorp#1484
tombuildsstuff
tombuildsstuff suggested changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments but this otherwise LGTM 👍

internal/services/sql/sql_server_resource.go Outdated Show resolved Hide resolved
website/docs/r/sql_server.html.markdown Outdated Show resolved Hide resolved
@favoretti favoretti added this to the v2.73.0 milestone Aug 19, 2021
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2021-08-19 at 14 03 31

tombuildsstuff
tombuildsstuff approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit ce49b8b into hashicorp:main Aug 19, 2021
tombuildsstuff added a commit that referenced this pull request Aug 19, 2021
@tombuildsstuff
updating to include #13048
a56e450
@github-actions
Copy link

This functionality has been released in v2.73.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation service/mssql Microsoft SQL Server size/L
Projects
None yet
Milestone
v2.73.0
Development

Successfully merging this pull request may close these issues.

New-Feature-Request SQL Threat Detection Policy
2 participants
@favoretti @tombuildsstuff