Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_storage_account - support for allow_shared_key_access property #13014

Merged
merged 5 commits into from
Aug 24, 2021
Merged

azurerm_storage_account - support for allow_shared_key_access property #13014

merged 5 commits into from
Aug 24, 2021

Conversation

catriona-m
Copy link
Member

fixes #11460

@catriona-m catriona-m mentioned this pull request Aug 16, 2021
Closed
@catriona-m catriona-m requested a review from a team August 20, 2021 09:34
katbyte
katbyte approved these changes Aug 20, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @catriona-m, aside from one comment about the name LGTM ❄️

internal/services/storage/storage_account_resource.go Outdated
@@ -239,6 +242,12 @@ func resourceStorageAccount() *pluginsdk.Resource {
Default: false,
},

"allow_shared_key_access": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we change this to

Suggested change
"allow_shared_key_access": {
"shared_key_access_enabled": {

for consistency with the rest of the provider? (its how we typically name bools)

@catriona-m catriona-m merged commit f629c44 into main Aug 24, 2021
@catriona-m catriona-m deleted the cm/storage_shared_key branch August 24, 2021 14:51
catriona-m added a commit that referenced this pull request Aug 24, 2021
@catriona-m
Update changelog for #13014
c2617e3
@tombuildsstuff tombuildsstuff added this to the v2.74.0 milestone Aug 24, 2021
@github-actions
Copy link

This functionality has been released in v2.74.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation size/L
Projects
None yet
Milestone
v2.74.0
Development

Successfully merging this pull request may close these issues.

Support for AllowSharedKeyAccess in azurerm_storage_account
3 participants
@catriona-m @katbyte @tombuildsstuff