Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid panic if RG or ASE do not exist when creating an App Service #12518

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Avoid panic if RG or ASE do not exist when creating an App Service #12518

merged 4 commits into from
Jul 8, 2021

Commits on Jul 8, 2021

  1. Avoid panic if RG or ASE do not exist when creating an App Service 

    Since the `Get` function of the `AppServices` client does not return an
error if the resource is not found, the code behaves as if everything is
fine and attempts to access fields of a struct that have not been
un-marshalled, since the API responded with 404.
    Kyriakos Oikonomakos committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    65a531e View commit details
    Browse the repository at this point in the history

  2. Don't update changelog yet

    Kyriakos Oikonomakos committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    99b02e7 View commit details
    Browse the repository at this point in the history

  3. Update azurerm/internal/services/web/app_service_resource.go 

    Co-authored-by: Steve <[email protected]>
    @koikonom @jackofallops
    koikonom and jackofallops authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    93e46cb View commit details
    Browse the repository at this point in the history

  4. go fmt

    Kyriakos Oikonomakos committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    a6a3881 View commit details
    Browse the repository at this point in the history